Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build of OpenBK7231N fails if ENABLE_LITTLEFS is undefined #929

Open
arnonm opened this issue Sep 27, 2023 · 3 comments
Open

Build of OpenBK7231N fails if ENABLE_LITTLEFS is undefined #929

arnonm opened this issue Sep 27, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@arnonm
Copy link

arnonm commented Sep 27, 2023

Describe the bug
undefining ENABLE_LITTLEFS in obk_config.h (as an effort to safe space) causes src/httpserver/reset_interface.c to fail compilation as LFS_BLOCKS_END is not defined

Firmware:

  • Version latest branch
  • Device - NA
  • Chip/model: BK7231N
  • Device config - NA

To Reproduce
Steps to reproduce the behavior:
add:

  1. #undef ENABLE_LITTLEFS in line 58 of obk_config.h
  2. build source
    Build fails
@openshwprojects
Copy link
Owner

Hello, I have fixed it in the last commit, can you check? Use #define ENABLE_LITTLEFS 0

@openshwprojects openshwprojects added the bug Something isn't working label Sep 30, 2023
@arnonm
Copy link
Author

arnonm commented Sep 30, 2023

httpserver/reset_interface.c still failed on LFS_BLOCKS_END
This workaround resolved it, but I don't know if it is valid

if PLATFORM_BK7231T
return http_rest_post_flash(request, START_ADR_OF_BK_PARTITION_OTA, LFS_BLOCKS_END);
#elif PLATFORM_BK7231N
#if ENABLE_LITTLEFS
return http_rest_post_flash(request, START_ADR_OF_BK_PARTITION_OTA, LFS_BLOCKS_END);
#else
return http_rest_post_flash(request, -1, -1);
#endif

@openshwprojects
Copy link
Owner

are you sure? it works for me without workaround:

#932

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants