Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EL9] New extensions build does not support variants #1080

Closed
travier opened this issue Dec 6, 2022 · 5 comments · Fixed by #1082 or coreos/coreos-assembler#3274
Closed

[EL9] New extensions build does not support variants #1080

travier opened this issue Dec 6, 2022 · 5 comments · Fixed by #1082 or coreos/coreos-assembler#3274

Comments

@travier
Copy link
Member

travier commented Dec 6, 2022

This probably need some small COSA changes too
@travier travier changed the title [EL9] Extensions build does not support variants [EL9] New extensions build does not support variants Dec 6, 2022
@travier
Copy link
Member Author

travier commented Dec 6, 2022

(I have in progress changes to fix this)

@travier travier mentioned this issue Dec 7, 2022
Merged
travier added a commit to travier/coreos-assembler that referenced this issue Dec 9, 2022
@travier
build-extensions-container: Pass variant as a container build argument
63ba41f 
Fixes: openshift/os#1080
Needs: openshift/os#1082
@travier travier mentioned this issue Dec 9, 2022
Merged
@travier
Copy link
Member Author

travier commented Dec 9, 2022

os PR: #1082
cosa PR: coreos/coreos-assembler#3274

@travier
Copy link
Member Author

travier commented Dec 12, 2022 •
edited
Loading

Still needs the COSA PR

@travier
Copy link
Member Author

travier commented Dec 12, 2022

/reopen

@openshift-ci openshift-ci bot reopened this Dec 12, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 12, 2022

@travier: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cgwalters pushed a commit to coreos/coreos-assembler that referenced this issue Dec 12, 2022
@travier @cgwalters
build-extensions-container: Pass variant as a container build argument
7be8698 
Fixes: openshift/os#1080
Needs: openshift/os#1082
travier added a commit to travier/coreos-assembler that referenced this issue Dec 16, 2022
@travier
build-extensions-container: Pass variant as a container build argument
f47283e 
Fixes: openshift/os#1080
Needs: openshift/os#1082
(cherry picked from commit 7be8698)
@travier travier mentioned this issue Dec 16, 2022
Merged
cgwalters pushed a commit to coreos/coreos-assembler that referenced this issue Dec 16, 2022
@travier @cgwalters
build-extensions-container: Pass variant as a container build argument
f819d4f 
Fixes: openshift/os#1080
Needs: openshift/os#1082
(cherry picked from commit 7be8698)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@travier