CR(D) Validation tests (Take 2)

[jeremyary]

With deps issues in master cleaned up, file history seems correct now. Also addresses the following requested changes from previous PR #90:

• test assist functions moved into test file instead of separate file
• moved to performance pkg in lieu of a new package containing only unit tests
• renamed suite (and test files) to match package name
• more accurate 'It ___' test names & comments on what validation actually means
  • also raised operator-utils issue to address this

[openshift-ci-robot]

Hi @jeremyary. Thanks for your PR.

I'm waiting for a openshift-kni member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[slintes]

nice, thanks!

/ok-to-test

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeremyary, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [slintes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[slintes]

Oh, github approve is lgtm + approved for prow, interesting.
Wanted to have a look at e2e test before merging

/hold

[jeremyary]

Wanted to have a look at e2e test before merging

last PR was an AWS region resource issue, are you suspecting the same here or wanting to look into something else? Just asking so I can learn more on project e2e and if there's more I can do locally to prep commits... I've got a lab, but my Inf guy gets itchy when I mention running functests against it ^_^

[slintes]

Wanted to have a look at e2e test before merging

last PR was an AWS region resource issue, are you suspecting the same here or wanting to look into something else? Just asking so I can learn more on project e2e and if there's more I can do locally to prep commits... I've got a lab, but my Inf guy gets itchy when I mention running functests against it ^_^

I'm not really suspecting something, but some dependencies were updated, so I just want to be on the safe side :) And because the e2e lane isn't mandatory (fails too often during cluster creation already), I put the hold to prevent merging before it runs. Btw, we run on GCP, because the RT kernel does not work on (every) EC2 VM.

[slintes]

all green :)

/hold cancel