Skip to content

Commit

Permalink
Workflow Versions Updates (#891)
Browse files Browse the repository at this point in the history
* Workflow Versions Updates
- Reinstated support for Node.js 14 to make 3.x compatible with dashboard dependencies.
- Removed OS 2.0 from Unreleased OS workflow
- Updated compatibility workflow with all the newest even-numbered releases.

Signed-off-by: Theo Truong <theotr@amazon.com>
  • Loading branch information
nhtruong authored Oct 30, 2024
1 parent b096274 commit 46f3d96
Show file tree
Hide file tree
Showing 5 changed files with 26 additions and 31 deletions.
20 changes: 8 additions & 12 deletions .github/workflows/compatibility.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,13 @@ jobs:
secured: ['true', 'false']
entry:
- { opensearch_version: 1.1.0 }
- { opensearch_version: 1.2.0 }
- { opensearch_version: 1.2.1 }
- { opensearch_version: 1.2.2 }
- { opensearch_version: 1.2.3 }
- { opensearch_version: 1.2.4 }
- { opensearch_version: 1.3.0 }
- { opensearch_version: 1.3.1 }
- { opensearch_version: 1.3.2 }
- { opensearch_version: 1.3.3 }
- { opensearch_version: 2.0.0 }
- { opensearch_version: 2.0.1 }
- { opensearch_version: 1.3.19 }
- { opensearch_version: 2.2.1 }
- { opensearch_version: 2.6.0 }
- { opensearch_version: 2.12.0 }
- { opensearch_version: 2.16.0 }
- { opensearch_version: 2.17.0 }
env:
OPENSEARCH_VERSION: ${{ matrix.entry.opensearch_version }}
SECURE_INTEGRATION: ${{ matrix.secured }}
Expand All @@ -50,10 +46,10 @@ jobs:
run: |
make cluster.clean cluster.opensearch.build cluster.opensearch.start
- name: Use Node.js 16.x
- name: Use Node.js 20.x
uses: actions/setup-node@v3
with:
node-version: 18.x
node-version: 20.x

- name: Install
run: |
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/integration-unreleased.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ jobs:
matrix:
entry:
- { node_version: '18.x', opensearch_ref: '1.x', jdk_version: '11' }
- { node_version: '18.x', opensearch_ref: '2.0', jdk_version: '17' }
- { node_version: '18.x', opensearch_ref: '2.x', jdk_version: '17' }
- { node_version: '18.x', opensearch_ref: 'main', jdk_version: '17' }
steps:
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:

strategy:
matrix:
node-version: [18.x, 20.x, 22.x]
node-version: [14.x, 16.x, 18.x, 20.x, 22.x]
os: [ubuntu-latest, windows-latest, macOS-13]

steps:
Expand Down Expand Up @@ -48,11 +48,11 @@ jobs:
run: |
npm uninstall -g yarn
npm i -g yarn@1.22.10
- name: Lint
if: matrix.node-version == '16.x'
run: |
yarn lint
# TODO: Uncomment the following block after updating the Codegen to support this linter
# - name: Lint
# if: matrix.node-version == '16.x'
# run: |
# yarn lint

- name: Unit test
run: |
Expand Down
22 changes: 11 additions & 11 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,10 @@ Inspired by [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
## [Unreleased]
### Added
### Dependencies
- Bumps `@babel/traverse` from 7.22.8 to 7.24.7
- Bumps `eslint-plugin-prettier` from 5.1.3 to 5.2.1
- Bumps `simple-git` from 3.24.0 to 3.26.0
- Bumps `aws4` from 1.13.0 to 1.13.2
### Changed
### Deprecated
### Removed
### Fixed
- Upgrade JSON11 from 1.1.2 to 2.0.0 to ensure UTF-8 safety when stringifying JSON data
- Fixed typo cause JSON11 parse will always be execute when json string has number inside
### Security

## [3.0.0]
Expand All @@ -24,12 +18,16 @@ Inspired by [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- Added missing API functions and modules.
- Added missing request and response types.
### Dependencies
- Bumps `micromatch` from 4.0.7 to 4.0.8
- Bumps `debug` from 4.3.6 to 4.3.7
- Bumps `simple-statistics` from 7.8.4 to 7.8.5
- Bumps `simple-git` from 3.25.0 to 3.26.0
- Bumps `@babel/traverse` from 7.22.8 to 7.24.7
- Bumps `@types/node` from 22.5.0 to 22.5.4
- Bumps `aws4` from 1.13.0 to 1.13.2
- Bumps `aws4` from 1.13.1 to 1.13.2
- Bumps `debug` from 4.3.6 to 4.3.7
- Bumps `eslint-plugin-prettier` from 5.1.3 to 5.2.1
- Bumps `micromatch` from 4.0.7 to 4.0.8
- Bumps `simple-git` from 3.24.0 to 3.26.0
- Bumps `simple-git` from 3.25.0 to 3.26.0
- Bumps `simple-statistics` from 7.8.4 to 7.8.5
### Changed
- All API functions are now generated from the OpenSearch API specification.
- API request and response types are now generated from the OpenSearch API specification.
Expand All @@ -39,8 +37,10 @@ Inspired by [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
### Removed
- Removed support for API param aliases. That is, the API functions now only accept params with the exact names specified in the OpenSearch API specification.
- Removed support for overriding HTTP methods in API functions.
- Removed support for Node.js 10 through 16. The minimum supported Node.js version is now 18.
- Removed support for Node.js 10 and 12. The minimum supported Node.js version is now 14.
### Fixed
- Upgrade JSON11 from 1.1.2 to 2.0.0 to ensure UTF-8 safety when stringifying JSON data
- Fixed typo cause JSON11 parse will always be executed when json string has number inside
### Security

## [2.12.0]
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@
"url": "https://github.com/opensearch-project/opensearch-js/issues"
},
"engines": {
"node": ">=18",
"node": ">=14",
"yarn": "^1.22.10"
},
"tsd": {
Expand Down

0 comments on commit 46f3d96

Please sign in to comment.