Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META Support confirmations when navigating away from unsaved changes #469

Open
1 of 4 tasks
ohltyler opened this issue Nov 7, 2024 · 0 comments
Open
1 of 4 tasks
Labels
enhancement New feature or request v2.20.0

Comments

@ohltyler
Copy link
Member

ohltyler commented Nov 7, 2024

There are several scenarios where we should warn users when exiting the edit page if there are unsaved changes. This includes:

  • refreshing browser Warn users on browser refresh if unsaved changes #470
  • navigating forward/back from browser. NOTE: testing with react router v5 Prompt in the WorkflowDetailHeader component seems to render multiple times. Seems like a known issue, and is historically buggy, and removed in v6. Further native js solutions may be the only path forward here.
  • navigation within OSD (breadcrumbs, different applications, etc.). NOTE: have run into same issues described above ^
  • navigation within plugin (clicking 'Close' button). NOTE: have run into same issues described above
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2.20.0
Projects
None yet
Development

No branches or pull requests

1 participant