Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also test with Groovy 2.5 on classpath for Gradle 4, 5 & 6 #4520

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

timtebeek
Copy link
Contributor

What's changed?

Add an integration test source set using Groovy 2.5.x, and unit tests where we've seen failures on that version.

What's your motivation?

Make it easier detect & troubleshoot parser issues specific to Groovy 2.

Anything in particular you'd like reviewers to focus on?

Wasn't sure on the Java version required for this source set, since Java 16+ requires Groovy 3+.

Have you considered any alternatives or workarounds?

I'd also tried a separate rewrite-groovy-test module, which makes it easier to also set a lower required Java version, but didn't like adding yet another top level project if we can avoid it. Getting mixed results locally and having a bit of trouble with IDE. Figured open a draft to see results in CI.

Any additional context

We've seen an uptick in parser issues reported following some recent-ish changes

@timtebeek timtebeek added bug Something isn't working parser-groovy labels Sep 24, 2024
@timtebeek timtebeek self-assigned this Sep 24, 2024
@timtebeek
Copy link
Contributor Author

This is getting frustrating; in an earlier iteration I'd seen these fail, but somehow it's not replicating right now. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parser-groovy
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant