Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove aliases #4

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Remove aliases #4

merged 2 commits into from
Sep 13, 2024

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Sep 13, 2024 •
edited
Loading

  • Patch source files to remove the need for aliases

@vicb
Copy link
Contributor Author

vicb commented Sep 13, 2024

Thanks for the review @petebacondarwin.
I rebased the PR

@vicb
Copy link
Contributor Author

vicb commented Sep 13, 2024

OOpsy, the url patch is still required until we land an updated unenv in wrangler next week.
I'll split the PR and update the description.

@vicb vicb changed the title Remove aliases and url patch Remove aliases Sep 13, 2024
@vicb vicb force-pushed the vicb branch 2 times, most recently from 3ae7db8 to 70238fa Compare September 13, 2024 08:14
@vicb vicb merged commit e795a1e into main Sep 13, 2024
2 of 4 checks passed
@vicb vicb deleted the vicb branch September 13, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petebacondarwin petebacondarwin petebacondarwin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vicb @petebacondarwin