Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debezium streaming integration #170

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

smallgod
Copy link
Collaborator

No description provided.

@dkayiwa
Copy link
Member

dkayiwa commented Oct 11, 2024

I love bringing debezium streaming in the mix 👍

api/pom.xml Outdated
@@ -73,6 +73,26 @@
<artifactId>commons-dbcp2</artifactId>
</dependency>

<!-- <dependency>-->
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete the comments

@@ -29,13 +34,33 @@ public class JdbcFlattenDatabaseDao implements FlattenDatabaseDao {
private static final String MYSQL_COMMENT_REGEX = "--.*(?=\\n)";
private static final String DELIMITER = "~-~-";

//private DebeziumListener debeziumListener = new DebeziumListener();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete commented code

@@ -16,7 +16,7 @@
import org.slf4j.LoggerFactory;
import org.springframework.transaction.annotation.Transactional;

import javax.annotation.PreDestroy;
//import javax.annotation.PreDestroy;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete commented code

pom.xml Outdated
@@ -122,6 +143,97 @@
</exclusions>
</dependency>

<!-- <dependency>-->
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete comments

}

public String getHistoryFilePath() {
return "/Users/smallgod/srv/downloads/dbhistory.dat"; // TODO: put in properties file
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not work on other people's machines / servers. Please put this on the properties file. In fact everything has this comment

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks @eudson for your comments.
I am doing to remove all comments and finalise on the cleanups

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants