-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debezium streaming integration #170
base: main
Are you sure you want to change the base?
Conversation
I love bringing debezium streaming in the mix 👍 |
api/pom.xml
Outdated
@@ -73,6 +73,26 @@ | |||
<artifactId>commons-dbcp2</artifactId> | |||
</dependency> | |||
|
|||
<!-- <dependency>--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please delete the comments
@@ -29,13 +34,33 @@ public class JdbcFlattenDatabaseDao implements FlattenDatabaseDao { | |||
private static final String MYSQL_COMMENT_REGEX = "--.*(?=\\n)"; | |||
private static final String DELIMITER = "~-~-"; | |||
|
|||
//private DebeziumListener debeziumListener = new DebeziumListener(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete commented code
@@ -16,7 +16,7 @@ | |||
import org.slf4j.LoggerFactory; | |||
import org.springframework.transaction.annotation.Transactional; | |||
|
|||
import javax.annotation.PreDestroy; | |||
//import javax.annotation.PreDestroy; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete commented code
pom.xml
Outdated
@@ -122,6 +143,97 @@ | |||
</exclusions> | |||
</dependency> | |||
|
|||
<!-- <dependency>--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete comments
} | ||
|
||
public String getHistoryFilePath() { | ||
return "/Users/smallgod/srv/downloads/dbhistory.dat"; // TODO: put in properties file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will not work on other people's machines / servers. Please put this on the properties file. In fact everything has this comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thanks @eudson for your comments.
I am doing to remove all comments and finalise on the cleanups
No description provided.