DRM-28: Map Location Page Crashes when DHIS2 Instance has no ORG Units #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samuelmale kindly please review |
mozzy11
reviewed
Apr 3, 2019
| @RequestParam(value = "openmrsLocations", required = true) String openmrsLocationName, | ||
| WebRequest webRequest) { | ||
| System.out.println("org unit does not exits and it is : " + dhis2OrgUnitCode); | ||
| String referer = webRequest.getHeader("Referer"); | ||
|
|
||
| if (dhis2OrgUnitCode.equals("")) { | ||
| if (dhis2OrgUnitCode == null || dhis2OrgUnitCode.isEmpty()) { |
There was a problem hiding this comment.
@gitcliff , can you take a look at the java convestions here https://wiki.openmrs.org/display/docs/Java+Conventions.
dhis2OrgUnitCode == null || dhis2OrgUnitCode.isEmpty() , this is discouraged. instead take use of the apache commons string utils library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRM-28: Map Location Page Crashes when DHIS2 Instance has no ORG Unit
link:https://issues.openmrs.org/browse/DRM-28
I set the DHIS2OrgUnits value to false and also checked the null value