Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(chore) Upgrade carbon #36

Merged
merged 4 commits into from
Oct 14, 2024
Merged

(chore) Upgrade carbon #36

merged 4 commits into from
Oct 14, 2024

Conversation

usamaidrsk
Copy link
Member

@usamaidrsk usamaidrsk commented Oct 10, 2024 •
edited
Loading

Requirements

  • This PR has a title that briefly describes the work done including a conventional commit type prefix and a Jira ticket number if applicable. See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.

Summary

This PR upgrades the carbon version to the latest and does the following:

  • Upgrade carbon version
  • Removes carbon from declarations
  • Update carbon styling imports and tokens
  • Update jest configc, and use framework mocked tests

Screenshots

Related Issue

Other

@NethmiRodrigo
Copy link
Contributor

@usamaidrsk do we need the .idea folder?

@usamaidrsk
Copy link
Member Author

@usamaidrsk do we need the .idea folder?

Right, I need to gitgnore that

NethmiRodrigo
NethmiRodrigo requested changes Oct 11, 2024
View reviewed changes
src/greeter/greeter.test.tsx Outdated Show resolved Hide resolved
src/greeter/greeter.test.tsx Outdated Show resolved Hide resolved
@NethmiRodrigo
Copy link
Contributor

Thanks @usamaidrsk! Some minor details,

@NethmiRodrigo
Copy link
Contributor

Thanks @usamaidrsk! LGTM!

@NethmiRodrigo NethmiRodrigo merged commit ba7dcbf into openmrs:main Oct 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NethmiRodrigo NethmiRodrigo NethmiRodrigo approved these changes

@denniskigen denniskigen Awaiting requested review from denniskigen

@ibacher ibacher Awaiting requested review from ibacher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@usamaidrsk @NethmiRodrigo @ibacher