Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getVoteChosen to also check ...metadata.memberAddress has voted #330

Open
jtrein opened this issue May 19, 2021 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@jtrein
Copy link
Member

jtrein commented May 19, 2021

We should also check the store.connectedMember.memberAddress against the vote's ...metadata.memberAddress. This is a safe check as delegates can vote. E.g. The account for a Snapshot Hub vote is set as the signer which could be a delegate of a member. An example:

  1. Member delegates to another address.
  2. Delegated-to address votes on a proposal.
  3. Member is logged into the Dapp, but the UI does not show they already voted.

The above can happen as the check is checking the currently logged in account's address against the vote's signer.

@jtrein jtrein added the enhancement New feature or request label May 19, 2021
@jtrein jtrein self-assigned this May 19, 2021
@jtrein jtrein added bug Something isn't working and removed enhancement New feature or request labels May 19, 2021
@jtrein jtrein changed the title Update getVoteChosen to instead check ...metadata.memberAddress has voted Update getVoteChosen to also check ...metadata.memberAddress has voted Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant