You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We shouldn't allow for users to send their own sig + data to verify sig on POST message as this means they could technically send any previous signature and data. I only implemented this as a temporary stop-gap solution so I could quickly sign the same data the moloch v3 contracts expected.
We need to find a good way to allow Snapshot Hub and Moloch v3 to accept the same signatures (or something to that effect).
The dependencies of this being rectified is changing which data the user signs for Snapshot Hub and Moloch v3. Today, they see many hashed conversions of formerly readable text strings (e.g. name: "A Good Proposal" -> nameHash: "0x3de4....") which is not ideal.
Expected behavior
We shouldn't allow for users to send their own sig + data to verify sig on
POST message
as this means they could technically send any previous signature and data. I only implemented this as a temporary stop-gap solution so I could quickly sign the same data the moloch v3 contracts expected.We need to find a good way to allow Snapshot Hub and Moloch v3 to accept the same signatures (or something to that effect).
The dependencies of this being rectified is changing which data the user signs for Snapshot Hub and Moloch v3. Today, they see many hashed conversions of formerly readable text strings (e.g.
name: "A Good Proposal" -> nameHash: "0x3de4...."
) which is not ideal.Actual behavior
Users can send any sig + data to verify sig.
Steps to reproduce the behavior
Sign some proposal data in Tribute Dapp.
cc: @adridadou @fforbeck
The text was updated successfully, but these errors were encountered: