Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sitemap editor: implement color temperature picker #2880

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mherwege
Copy link
Contributor

Closes: #2852 (comment)

Related to: openhab/openhab-core#3891

This PR implements configuring a color temperature picker in the sitemap builder UI.

It also does some visualisation improvements of names and labels (by defaults shows item label in treeview, analogous to model treeview).

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Copy link

relativeci bot commented Nov 18, 2024

#2498 Bundle Size — 10.87MiB (+0.02%).

800c925(current) vs 7c3d114 main#2496(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 4 changes Regression 2 regressions
                 Current
#2498
     Baseline
#2496
Regression  Initial JS 1.91MiB(+0.34%) 1.91MiB
Regression  Initial CSS 577.48KiB(+0.03%) 577.31KiB
Change  Cache Invalidation 22.98% 17.59%
No change  Chunks 226 226
No change  Assets 249 249
Change  Modules 2942(+0.07%) 2940
No change  Duplicate Modules 152 152
No change  Duplicate Code 1.8% 1.8%
No change  Packages 96 96
No change  Duplicate Packages 2 2
Bundle size by type  Change 2 changes Regression 2 regressions
                 Current
#2498
     Baseline
#2496
Regression  JS 9.08MiB (+0.02%) 9.08MiB
Regression  CSS 864.45KiB (+0.05%) 864KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch mherwege:colortemperaturepickerProject dashboard


Generated by RelativeCIDocumentationReport issue

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Colortemperaturepicker in sitemap builder
1 participant