Interactive SVG background: Allow processing whole SVG group for state #2872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
#2490 Bundle Size — 10.87MiB (~+0.01%).8f9ca12(current) vs e3daf94 main#2489(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
| Current #2490 |
Baseline #2489 |
|
|---|---|---|
 Initial JS |
1.91MiB(~+0.01%) |
1.91MiB |
 Initial CSS |
577.31KiB |
577.31KiB |
 Cache Invalidation |
17.55% |
18.66% |
| Chunks |
226 |
226 |
| Assets |
249 |
249 |
| Modules |
2940 |
2940 |
| Duplicate Modules |
152 |
152 |
| Duplicate Code |
1.8% |
1.8% |
| Packages |
96 |
96 |
| Duplicate Packages |
2 |
2 |
Bundle size by type 1 change 1 regression
| Current #2490 |
Baseline #2489 |
|
|---|---|---|
| JS |
9.08MiB (~+0.01%) |
9.08MiB |
| CSS |
864KiB |
864KiB |
| Fonts |
526.1KiB |
526.1KiB |
| Media |
295.6KiB |
295.6KiB |
| IMG |
140.74KiB |
140.74KiB |
| HTML |
1.38KiB |
1.38KiB |
| Other |
871B |
871B |
Bundle analysis report Branch stefan-hoehn:interactive_backgro... Project dashboard
Generated by RelativeCI Documentation Report issue
florian-h05
reviewed
Nov 16, 2024
bundles/org.openhab.ui/web/src/components/widgets/layout/oh-canvas-embedded-svg-mixin.js
Outdated
Show resolved
Hide resolved
bundles/org.openhab.ui/web/src/components/widgets/layout/oh-canvas-embedded-svg-mixin.js
Outdated
Show resolved
Hide resolved
bundles/org.openhab.ui/web/src/components/widgets/layout/oh-canvas-embedded-svg-mixin.js
Show resolved
Hide resolved
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
florian-h05
approved these changes
Nov 16, 2024
florian-h05
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement for interactive SVG backgrounds:
Allows to flash and handle state on whole SVG groups without a proxy by using the group's path elements instead, e.g. this whole group can be used directly
svg-groups.mov