Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages list: Don't allow selecting overview page for removal #2856

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

florian-h05
Copy link
Contributor

The overview page cannot be removed, so do not allow to select it for removal.

The overview page cannot be removed, so do not allow to select it for removal.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
@florian-h05 florian-h05 added this to the 4.3 milestone Nov 1, 2024
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Nov 1, 2024
@florian-h05 florian-h05 changed the title Pages list: Don't allow selecting overview page Pages list: Don't allow selecting overview page for removal Nov 1, 2024
Copy link

relativeci bot commented Nov 1, 2024

#2451 Bundle Size — 10.86MiB (~+0.01%).

504c467(current) vs 3022654 main#2449(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
#2451
     Baseline
#2449
No change  Initial JS 1.9MiB 1.9MiB
No change  Initial CSS 577.31KiB 577.31KiB
Change  Cache Invalidation 17.64% 18.47%
No change  Chunks 226 226
No change  Assets 249 249
No change  Modules 2938 2938
No change  Duplicate Modules 151 151
No change  Duplicate Code 1.87% 1.87%
No change  Packages 96 96
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2451
     Baseline
#2449
Regression  JS 9.07MiB (~+0.01%) 9.07MiB
No change  CSS 864.37KiB 864.37KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch florian-h05:pages-remove-overvie...Project dashboard


Generated by RelativeCIDocumentationReport issue

@florian-h05 florian-h05 merged commit 00e7f10 into openhab:main Nov 1, 2024
8 checks passed
@florian-h05 florian-h05 deleted the pages-remove-overview branch November 1, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant