Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend search of Add-on store to descriptions #2870

Open
holgerfriedrich opened this issue Nov 16, 2024 · 1 comment
Open

Extend search of Add-on store to descriptions #2870

holgerfriedrich opened this issue Nov 16, 2024 · 1 comment
Labels
enhancement New feature or request main ui Main UI

Comments

@holgerfriedrich
Copy link
Member

The problem

openhab/openhab-addons#17682 (comment)

We have two add-ons, ism8 and wolfsmartset (you will need one or the other depending on the smart home interface installed in the heating system). When a user types "wolf" into the search field of the add-on store, I would like to see both add-ons shown.

Current behaviour is as follows: Whey I search for "wolf", I get only the latter.

The search mechanism seems to look at the name of the binding, but not at the description (which contains Wolf for both add-ons).

Your suggestion

Extending the search to the description field.
This may lead to a lot of false positives. Therefore, we might restrict this feature, e.g., use the description only if the search term has at least 3 letters.

Your environment

Additional information

We discussed adding the term "Wolf" to the binding name in openhab/openhab-addons#17747. This would basically mean that we rename the binding - not my preferred solution.

I do not know about the current implementation of the search and how easy it would be to extend it to the description.

@lsiepel
Copy link

lsiepel commented Nov 16, 2024

An alternative might be to add an optional xml element 'searchTerms' (or something similar). The description was never meant for this and might be causing false positives/unrelated results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

No branches or pull requests

2 participants