Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kermi] add Logo for Kermi Modbus Binding #2410

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Conversation

KaaNee
Copy link
Contributor

@KaaNee KaaNee commented Nov 22, 2024

Logo for Modbus Kermi Binding.
MR: openhab/openhab-addons#16329

Signed-off-by: KaiNative <github@kaineuhaus.com>
Copy link

netlify bot commented Nov 22, 2024

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Built without sensitive environment variables

Name Link
🔨 Latest commit 50b81e5
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/6749c81ad296f00008db94ec
😎 Deploy Preview https://deploy-preview-2410--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intentionally leave so much space around the logo?

@KaaNee
Copy link
Contributor Author

KaaNee commented Nov 28, 2024

@stefan-hoehn No. I took the original from the company. Should it be trimmed to fit better?

@stefan-hoehn
Copy link
Contributor

Yeah, that would be awesome.

exchanged logo with smaller version (removed border)

Signed-off-by: KaiNative <github@kaineuhaus.com>
@KaaNee
Copy link
Contributor Author

KaaNee commented Nov 29, 2024

@stefan-hoehn please re-check, trimmed logo borders.
Ok, now ?

Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, thanks.

@stefan-hoehn stefan-hoehn added this to the 4.3 milestone Nov 29, 2024
@stefan-hoehn stefan-hoehn merged commit 0522f3f into openhab:main Nov 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants