Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadlink logo for broadlink binding #2277

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Conversation

AntonJansen
Copy link
Contributor

This is the logo for the upcoming broadlink binding, as defined in the PR openhab/openhab-addons#16273.
It improves the resolution of the existing logo.

This is the logo for the upcoming broadlink binding, as defined in the PR
openhab/openhab-addons#16273

Signed-off-by: AntonJansen <gradius@fmf.nl>
Copy link

netlify bot commented Mar 26, 2024

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Built without sensitive environment variables

Name Link
🔨 Latest commit 69171e4
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/67115d8071c5f50008be8366
😎 Deploy Preview https://deploy-preview-2277--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@florian-h05
Copy link
Contributor

florian-h05 commented Mar 29, 2024

Can you please also provide an SVG logo instead? SVG logos are now supported with openHAB 4.2.0 ...

@stefan-hoehn stefan-hoehn added the stat: dependency 💥 This issue/pr has a dependency in another repo label Mar 29, 2024
@stefan-hoehn
Copy link
Contributor

please ping me, when the binding is eventually done. You might want to rather consider and mark this PR as DRAFT in the meantime.

@AntonJansen
Copy link
Contributor Author

@stefan-hoehn the binding finally after many months has been merged with the main line in the openhab-addons repository. Please merge this.

Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@stefan-hoehn stefan-hoehn removed the stat: dependency 💥 This issue/pr has a dependency in another repo label Oct 18, 2024
@stefan-hoehn stefan-hoehn added this to the 4.3 milestone Oct 18, 2024
@stefan-hoehn stefan-hoehn merged commit e80f02c into openhab:main Oct 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants