Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color utils actions #2154

Merged
merged 4 commits into from
Nov 19, 2023
Merged

Conversation

lolodomo
Copy link
Contributor

Related to openhab/openhab-core#3749

Signed-off-by: Laurent Garnier lg.hc@free.fr

Related to openhab/openhab-core#3749

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Copy link

netlify bot commented Nov 12, 2023

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Name Link
🔨 Latest commit b2843d6
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/655a05480bf2b700083d5427
😎 Deploy Preview https://deploy-preview-2154--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

addons/actions.md Outdated Show resolved Hide resolved
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx! Unfortunately there is another file you did not change that is breaking the build.
@lolodomo The easiest thing would be maybe if you would quickly fix the issues in installation/synonology.md yourself.
I could also do this but with my own PR (I have already started doing that) but then you have to merge that anyway.
Being a maintainer yourself, is there any easier way to do that?

@lolodomo
Copy link
Contributor Author

@stefan-hoehn : if you merge a fix for synonology.md, then I will merge the updated main branch into all my branches and the problem will be solved. Very easy. So if you know what has to be fixed in synonology.md, please do it and merge it.

@stefan-hoehn
Copy link
Contributor

@stefan-hoehn : if you merge a fix for synonology.md, then I will merge the updated main branch into all my branches and the problem will be solved. Very easy. So if you know what has to be fixed in synonology.md, please do it and merge it.

Ok, fine, I have discovered even more in a different PR, so that's be me task today to verify all other places as well. I'll fix it and then rerun the build here.

@lolodomo
Copy link
Contributor Author

Ok, fine, I have discovered even more in a different PR, so that's be me task today to verify all other places as well. I'll fix it and then rerun the build here.

I just submitted a PR fixing the problems in synology.md.
Please check and merge it.

@stefan-hoehn stefan-hoehn added this to the 4.1 milestone Nov 19, 2023
@stefan-hoehn
Copy link
Contributor

@lolodomo I fixed that one issue #2160 and reran the build here but it still fails.

Could it be that your PR needs to be rebased? I could do
image
but then it would be automatically merged without the build being run.

@lolodomo
Copy link
Contributor Author

Yes, I will rebase. I do it in half an hour.

@stefan-hoehn stefan-hoehn added the stat: dependency 💥 This issue/pr has a dependency in another repo label Nov 19, 2023
@lolodomo
Copy link
Contributor Author

All my PRs are fine now after a rebase. You will be able to merge them ;)

@stefan-hoehn stefan-hoehn merged commit 93dde60 into openhab:main Nov 19, 2023
5 checks passed
@lolodomo lolodomo deleted the actions_colorutil branch November 19, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: dependency 💥 This issue/pr has a dependency in another repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants