Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update services.cfg #1697

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update services.cfg #1697

wants to merge 2 commits into from

Conversation

lo92fr
Copy link

@lo92fr lo92fr commented Nov 29, 2024

fix services.cfg to re-enable startup level 30 in development environment
Link to issue #3823 in openhab-core : openhab/openhab-core#3823

fix services.cfg to re-enable startup level 30 in development environment

Signed-off-by: lo92fr <laurent@clae.net>
@lo92fr lo92fr requested a review from a team as a code owner November 29, 2024 11:51
Comment on lines 21 to 22
#startlevel:30=persistence:restore // do not rely on the presence of a persistence service in the IDE
startlevel:20=dsl:items,managed:item,dsl:things,managed:thing,managed:itemchannellink,dsl:persist,managed:metadata
startlevel:30=persistence:services,persistence:restore,automation:scriptEngineFactories
Copy link
Contributor

@lolodomo lolodomo Nov 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the current comment ?
In IDE, we should be able to start openHAB even without any persistence installed.
Is it still the case with your change ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, don't look at the comment, sorry.

So I don't know what are good modification to solve this.
The matter is that we add new marker as part of @J-N-K modification on September 9.
And we except to openhab go to level 30 to have ThingManagerImpl correctly initialized !

Laurent.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Laurent,

This is related to the issue : openhab/openhab-core#3823.
Don't know if you see my comment this morning about tracing why we have thing not get initialized in development environment.

Copy link
Contributor

@lolodomo lolodomo Dec 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take care, you have two different lines for start level 20.
You have to keep only one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO you. eed to remove the second line for start level 20 and should remove the persistence:restore marker. The other two markers rely on bundle trackers and will be set when all installed bundles (persistence or scripting) are ACTIVE or no bundle of the given type is installed. persistence:restore in principle expects a persistence bundle to be installed which might not be the case in a development environment.

@lolodomo
Copy link
Contributor

lolodomo commented Dec 1, 2024

Tested with

startlevel:20=dsl:items,managed:item,dsl:things,managed:thing,managed:itemchannellink,dsl:persist,managed:metadata
startlevel:30=persistence:services,persistence:restore,automation:scriptEngineFactories

in Eclipse and I can confirm that our problem with managed things remaining in NOT_YET_READY status at startup is fixed.

@lolodomo
Copy link
Contributor

lolodomo commented Dec 1, 2024

@openhab/distro-maintainers @openhab/core-maintainers : this is a critical fix to review ASAP, we are no more able since few weeks/months to use managed things when playing with Eclipse IDE. The current comment for start level 30 should also be considered.

@lo92fr : please adjust your fix as you kept two lines for start level 20.

Comment on lines 21 to 22
#startlevel:30=persistence:restore // do not rely on the presence of a persistence service in the IDE
startlevel:20=dsl:items,managed:item,dsl:things,managed:thing,managed:itemchannellink,dsl:persist,managed:metadata
startlevel:30=persistence:services,persistence:restore,automation:scriptEngineFactories
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO you. eed to remove the second line for start level 20 and should remove the persistence:restore marker. The other two markers rely on bundle trackers and will be set when all installed bundles (persistence or scripting) are ACTIVE or no bundle of the given type is installed. persistence:restore in principle expects a persistence bundle to be installed which might not be the case in a development environment.

fix double line form startlevel:20, and remove persistence:restore on startlevel:30

Signed-off-by: lo92fr <laurent@clae.net>
@lo92fr
Copy link
Author

lo92fr commented Dec 1, 2024

@J-N-K, @lolodomo,

I've push the change about duplicate line and removing persistence:restore on startlevel:30.

Laurent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants