From b25fc4d35623aae23874ce33fe55be8076ca168a Mon Sep 17 00:00:00 2001 From: Wouter Born Date: Fri, 5 Jan 2024 13:03:05 +0100 Subject: [PATCH] Sort POMs and apply Spotless Signed-off-by: Wouter Born --- distributions/openhab-addons/pom.xml | 152 +++---- distributions/openhab-demo/pom.xml | 70 ++-- distributions/openhab-verify/pom.xml | 142 +++---- distributions/openhab/pom.xml | 546 ++++++++++++------------ distributions/pom.xml | 8 +- features/addons/pom.xml | 80 ++-- features/distro-kar/pom.xml | 112 ++--- features/distro/pom.xml | 112 ++--- features/pom.xml | 32 +- pom.xml | 606 ++++++++++++++------------- 10 files changed, 940 insertions(+), 920 deletions(-) diff --git a/distributions/openhab-addons/pom.xml b/distributions/openhab-addons/pom.xml index 2ec66854be..b74f775564 100644 --- a/distributions/openhab-addons/pom.xml +++ b/distributions/openhab-addons/pom.xml @@ -1,83 +1,85 @@ - + + - 4.0.0 + 4.0.0 - - org.openhab.distro - pom-distributions - 4.2.0-SNAPSHOT - + + org.openhab.distro + pom-distributions + 4.2.0-SNAPSHOT + - openhab-addons - kar + openhab-addons + kar - openHAB Add-ons Aggregator + openHAB Add-ons Aggregator - - - org.openhab.distro - addons - ${project.version} - features - xml - - - org.openhab.addons.features.karaf - org.openhab.addons.features.karaf.openhab-addons - ${project.version} - features - xml - - - org.openhab.addons.features.karaf - openhab-binding-zigbee - ${project.version} - features - xml - - - org.openhab.ui.features - org.openhab.ui.features - ${project.version} - features - xml - - + + + org.openhab.distro + addons + ${project.version} + features + xml + + + org.openhab.addons.features.karaf + org.openhab.addons.features.karaf.openhab-addons + ${project.version} + features + xml + + + org.openhab.addons.features.karaf + openhab-binding-zigbee + ${project.version} + features + xml + + + org.openhab.ui.features + org.openhab.ui.features + ${project.version} + features + xml + + - - - - org.apache.karaf.tooling - karaf-maven-plugin - true - - 80 - true - true - - true - false - true - true - true - - true - - false - - - - - - generate-features-file - generate-resources - - features-generate-descriptor - - - - - - + + + + org.apache.karaf.tooling + karaf-maven-plugin + true + + 80 + true + true + + true + false + true + true + true + + true + + false + + + + + + generate-features-file + + features-generate-descriptor + + generate-resources + + + + + diff --git a/distributions/openhab-demo/pom.xml b/distributions/openhab-demo/pom.xml index cc61d7fe8a..a3594d017f 100644 --- a/distributions/openhab-demo/pom.xml +++ b/distributions/openhab-demo/pom.xml @@ -1,40 +1,42 @@ - - 4.0.0 + + + 4.0.0 - - org.openhab.distro - pom-distributions - 4.2.0-SNAPSHOT - + + org.openhab.distro + pom-distributions + 4.2.0-SNAPSHOT + - openhab-demo - pom + openhab-demo + pom - openHAB Demo + openHAB Demo - - - - org.apache.maven.plugins - maven-assembly-plugin - - - archive - package - - single - - - - src/main/descriptors/archive.xml - - false - posix - - - - - - + + + + org.apache.maven.plugins + maven-assembly-plugin + + + archive + + single + + package + + + src/main/descriptors/archive.xml + + false + posix + + + + + + diff --git a/distributions/openhab-verify/pom.xml b/distributions/openhab-verify/pom.xml index d86fd96008..50b52a8150 100644 --- a/distributions/openhab-verify/pom.xml +++ b/distributions/openhab-verify/pom.xml @@ -1,78 +1,80 @@ - + + - 4.0.0 + 4.0.0 - - org.openhab.distro - pom-distributions - 4.2.0-SNAPSHOT - + + org.openhab.distro + pom-distributions + 4.2.0-SNAPSHOT + - openhab-verify - pom + openhab-verify + pom - openHAB Feature Verification + openHAB Feature Verification - - - org.apache.karaf.features - framework - ${karaf.version} - kar - provided - - - ${project.groupId} - openhab-addons - ${project.version} - kar - provided - - - ${project.groupId} - distro-kar - ${project.version} - kar - provided - - + + + org.apache.karaf.features + framework + ${karaf.version} + kar + provided + + + ${project.groupId} + openhab-addons + ${project.version} + kar + provided + + + ${project.groupId} + distro-kar + ${project.version} + kar + provided + + - - - - org.apache.karaf.tooling - karaf-maven-plugin - - - verify - process-resources - - verify - - - - mvn:org.apache.karaf.features/framework/${karaf.version}/xml/features - mvn:org.apache.karaf.features/standard/${karaf.version}/xml/features - mvn:org.apache.karaf.features/specs/${karaf.version}/xml/features - mvn:${project.groupId}/addons/${project.version}/xml/features - mvn:${project.groupId}/distro/${project.version}/xml/features - - org.apache.karaf.features:framework - ${oh.java.version} - - framework - - - openhab-* - - false - true - first - - - - - - + + + + org.apache.karaf.tooling + karaf-maven-plugin + + + verify + + verify + + process-resources + + + mvn:org.apache.karaf.features/framework/${karaf.version}/xml/features + mvn:org.apache.karaf.features/standard/${karaf.version}/xml/features + mvn:org.apache.karaf.features/specs/${karaf.version}/xml/features + mvn:${project.groupId}/addons/${project.version}/xml/features + mvn:${project.groupId}/distro/${project.version}/xml/features + + org.apache.karaf.features:framework + ${oh.java.version} + + framework + + + openhab-* + + false + true + first + + + + + + diff --git a/distributions/openhab/pom.xml b/distributions/openhab/pom.xml index bdb8695b08..9e67e02bea 100644 --- a/distributions/openhab/pom.xml +++ b/distributions/openhab/pom.xml @@ -1,281 +1,283 @@ - - 4.0.0 + + + 4.0.0 - - org.openhab.distro - pom-distributions - 4.2.0-SNAPSHOT - + + org.openhab.distro + pom-distributions + 4.2.0-SNAPSHOT + - openhab - karaf-assembly + openhab + karaf-assembly - openHAB Distribution - This is the distribution of openHAB + openHAB Distribution + This is the distribution of openHAB - - - org.apache.karaf.features - framework - ${karaf.version} - kar - - - org.apache.karaf.features - standard - ${karaf.version} - features - xml - compile - - - org.apache.karaf.features - specs - ${karaf.version} - features - xml - compile - - - org.openhab.distro - distro-kar - ${project.version} - kar - provided - - - org.openhab.distro - distro - ${project.version} - features - xml - runtime - - - org.openhab.distro - openhab-addons - ${project.version} - features - xml - runtime - - + + + org.apache.karaf.features + framework + ${karaf.version} + kar + + + org.apache.karaf.features + standard + ${karaf.version} + features + xml + compile + + + org.apache.karaf.features + specs + ${karaf.version} + features + xml + compile + + + org.openhab.distro + distro-kar + ${project.version} + kar + provided + + + org.openhab.distro + distro + ${project.version} + features + xml + runtime + + + org.openhab.distro + openhab-addons + ${project.version} + features + xml + runtime + + - - - - - org.codehaus.mojo - exec-maven-plugin - 3.1.0 - - - org.openhab.util - pax-web-patch - 1.0.0 - - - - - + - - - - src/main/resources - false - - **/* - - - - src/main/filtered-resources - true - - **/* - - - + + + + false + src/main/resources + + **/* + + + + true + src/main/filtered-resources + + **/* + + + + + + + org.codehaus.mojo + exec-maven-plugin + 3.1.0 + + + org.openhab.util + pax-web-patch + 1.0.0 + + + + + - - - org.apache.maven.plugins - maven-dependency-plugin - 3.6.0 - - - copy - process-resources - - copy - - - - - org.openhab.core.tools - upgradetool - ${project.version} - jar - jar-with-dependencies - true - ${project.build.directory}/assembly/bin - upgradetool.jar - - - org.openhab.addons.features.karaf - org.openhab.addons.features.karaf.openhab-addons-external - ${project.version} - xml - addons - true - ${project.build.directory}/addon-xml - addons.xml - - - - - - unpack - process-resources - - unpack - - - - - org.openhab.addons.bundles - org.openhab.binding.zigbee - ${project.version} - jar - **/addon.xml - ${project.build.directory}/addon-xml/org.openhab.binding.zigbee - - - org.openhab.addons.bundles - org.openhab.binding.zwave - ${project.version} - jar - **/addon.xml - ${project.build.directory}/addon-xml/org.openhab.binding.zwave - - - - - - - - org.codehaus.gmaven - groovy-maven-plugin - 2.1.1 - - - org.apache.groovy - groovy-all - 4.0.13 - pom - - - - - - execute - - process-resources - - ${project.basedir}/merge-addon-info.groovy - - - - - - org.apache.maven.plugins - maven-resources-plugin - 3.3.1 - - \ - - - - process-resources - - resources - - - - - - org.apache.karaf.tooling - karaf-maven-plugin - - - wrapper - wrap - - - eventadmin - - - jaas - shell - ssh - bundle - config - deployer - diagnostic - feature - instance - kar - log - package - service - system - openhab-runtime-base - openhab-runtime-ui - - false - false - - - - org.codehaus.mojo - exec-maven-plugin - - - prepare-package - - java - - - - - org.openhab.patch.ClassPathUtilPatcher - - ${project.basedir}/target/assembly/system/org/ops4j/pax/web/pax-web-api - - True - - - - org.apache.maven.plugins - maven-assembly-plugin - - - archive - package - - single - - - - src/main/descriptors/archive.xml - - false - posix - - - - - - + + + org.apache.maven.plugins + maven-dependency-plugin + 3.6.0 + + + copy + + copy + + process-resources + + + + org.openhab.core.tools + upgradetool + ${project.version} + jar + jar-with-dependencies + true + ${project.build.directory}/assembly/bin + upgradetool.jar + + + org.openhab.addons.features.karaf + org.openhab.addons.features.karaf.openhab-addons-external + ${project.version} + xml + addons + true + ${project.build.directory}/addon-xml + addons.xml + + + + + + unpack + + unpack + + process-resources + + + + org.openhab.addons.bundles + org.openhab.binding.zigbee + ${project.version} + jar + **/addon.xml + ${project.build.directory}/addon-xml/org.openhab.binding.zigbee + + + org.openhab.addons.bundles + org.openhab.binding.zwave + ${project.version} + jar + **/addon.xml + ${project.build.directory}/addon-xml/org.openhab.binding.zwave + + + + + + + + org.codehaus.gmaven + groovy-maven-plugin + 2.1.1 + + + org.apache.groovy + groovy-all + 4.0.13 + pom + + + + + + execute + + process-resources + + ${project.basedir}/merge-addon-info.groovy + + + + + + org.apache.maven.plugins + maven-resources-plugin + 3.3.1 + + \ + + + + process-resources + + resources + + + + + + org.apache.karaf.tooling + karaf-maven-plugin + + + wrapper + wrap + + + eventadmin + + + jaas + shell + ssh + bundle + config + deployer + diagnostic + feature + instance + kar + log + package + service + system + openhab-runtime-base + openhab-runtime-ui + + false + false + + + + org.codehaus.mojo + exec-maven-plugin + + org.openhab.patch.ClassPathUtilPatcher + + ${project.basedir}/target/assembly/system/org/ops4j/pax/web/pax-web-api + + True + + + + + java + + prepare-package + + + + + org.apache.maven.plugins + maven-assembly-plugin + + + archive + + single + + package + + + src/main/descriptors/archive.xml + + false + posix + + + + + + diff --git a/distributions/pom.xml b/distributions/pom.xml index c7f5d4a63d..123080ff76 100644 --- a/distributions/pom.xml +++ b/distributions/pom.xml @@ -1,4 +1,6 @@ - + + 4.0.0 @@ -9,10 +11,10 @@ pom-distributions - openHAB Distributions - pom + openHAB Distributions + openhab-addons openhab-demo diff --git a/features/addons/pom.xml b/features/addons/pom.xml index 91f3f7a573..142a987361 100644 --- a/features/addons/pom.xml +++ b/features/addons/pom.xml @@ -1,46 +1,48 @@ - + + - 4.0.0 + 4.0.0 - - org.openhab.distro - pom-features - 4.2.0-SNAPSHOT - + + org.openhab.distro + pom-features + 4.2.0-SNAPSHOT + - addons - feature + addons + feature - openHAB Add-ons - These are add-ons in separate repositories (which do not have their own Karaf feature defined). + openHAB Add-ons + These are add-ons in separate repositories (which do not have their own Karaf feature defined). - - - - org.apache.karaf.tooling - karaf-maven-plugin - true - - 80 - true - true - - true - false - true - true - - - - generate-features-file - generate-resources - - features-generate-descriptor - - - - - - + + + + org.apache.karaf.tooling + karaf-maven-plugin + true + + 80 + true + true + + true + false + true + true + + + + generate-features-file + + features-generate-descriptor + + generate-resources + + + + + diff --git a/features/distro-kar/pom.xml b/features/distro-kar/pom.xml index e392d7532d..ed52a8ebbe 100644 --- a/features/distro-kar/pom.xml +++ b/features/distro-kar/pom.xml @@ -1,63 +1,65 @@ - + + - 4.0.0 + 4.0.0 - - org.openhab.distro - pom-features - 4.2.0-SNAPSHOT - + + org.openhab.distro + pom-features + 4.2.0-SNAPSHOT + - distro-kar - kar + distro-kar + kar - openHAB Distro Feature KAR - openHAB Distro Feature KAR + openHAB Distro Feature KAR + openHAB Distro Feature KAR - - - ${project.groupId} - distro - ${project.version} - features - xml - - + + + ${project.groupId} + distro + ${project.version} + features + xml + + - - - - org.apache.karaf.tooling - karaf-maven-plugin - true - - 80 - true - true - - true - false - true - true - true - - true - - false - - - - - - generate-features-file - generate-resources - - features-generate-descriptor - - - - - - + + + + org.apache.karaf.tooling + karaf-maven-plugin + true + + 80 + true + true + + true + false + true + true + true + + true + + false + + + + + + generate-features-file + + features-generate-descriptor + + generate-resources + + + + + diff --git a/features/distro/pom.xml b/features/distro/pom.xml index df808cd569..33e98c0ac5 100644 --- a/features/distro/pom.xml +++ b/features/distro/pom.xml @@ -1,63 +1,65 @@ - + + - 4.0.0 + 4.0.0 - - org.openhab.distro - pom-features - 4.2.0-SNAPSHOT - + + org.openhab.distro + pom-features + 4.2.0-SNAPSHOT + - distro - feature + distro + feature - openHAB Distro Feature - openHAB Distro Feature + openHAB Distro Feature + openHAB Distro Feature - - - org.openhab.core.features.karaf - org.openhab.core.features.karaf.openhab-core - ${ohc.version} - features - xml - - - org.openhab.core.features.karaf - org.openhab.core.features.karaf.openhab-tp - ${ohc.version} - features - xml - - + + + org.openhab.core.features.karaf + org.openhab.core.features.karaf.openhab-core + ${ohc.version} + features + xml + + + org.openhab.core.features.karaf + org.openhab.core.features.karaf.openhab-tp + ${ohc.version} + features + xml + + - - - - org.apache.karaf.tooling - karaf-maven-plugin - true - - 50 - true - true - - true - false - true - true - - - - generate-features-file - generate-resources - - features-generate-descriptor - - - - - - + + + + org.apache.karaf.tooling + karaf-maven-plugin + true + + 50 + true + true + + true + false + true + true + + + + generate-features-file + + features-generate-descriptor + + generate-resources + + + + + diff --git a/features/pom.xml b/features/pom.xml index 9337b230ef..cde2150f76 100644 --- a/features/pom.xml +++ b/features/pom.xml @@ -1,22 +1,24 @@ - + + - - org.openhab.distro - pom - 4.2.0-SNAPSHOT - + 4.0.0 - 4.0.0 - pom-features + + org.openhab.distro + pom + 4.2.0-SNAPSHOT + + pom-features - openHAB Features + pom - pom + openHAB Features - - distro - distro-kar - addons - + + distro + distro-kar + addons + diff --git a/pom.xml b/pom.xml index 6b5ca5ce74..eac73030e1 100644 --- a/pom.xml +++ b/pom.xml @@ -1,322 +1,324 @@ - - 4.0.0 + + + 4.0.0 - - org.openhab - openhab-super-pom - [1.0, 2.0) - + + org.openhab + openhab-super-pom + [1.0, 2.0) + - org.openhab.distro - pom - 4.2.0-SNAPSHOT - pom + org.openhab.distro + pom + 4.2.0-SNAPSHOT + pom - openHAB Distribution - This is the openHAB distribution + openHAB Distribution + This is the openHAB distribution - - - Eclipse Public License 2.0 - https://www.eclipse.org/legal/epl-2.0/ - - + + + Eclipse Public License 2.0 + https://www.eclipse.org/legal/epl-2.0/ + + - - scm:git:${scm.gitBaseUrl}/openhab-distro.git - scm:git:${scm.gitBaseUrl}/openhab-distro.git - https://github.com/openhab/openhab-distro - HEAD - + + features + distributions + - - https://github.com/openhab/openhab-distro/issues - GitHub - + + scm:git:${scm.gitBaseUrl}/openhab-distro.git + scm:git:${scm.gitBaseUrl}/openhab-distro.git + HEAD + https://github.com/openhab/openhab-distro + - - - jfrog-release - ${oh.repo.distBaseUrl}/libs-release-local - - - jfrog - ${oh.repo.snapshotBaseUrl}/libs-snapshot-local - - + + GitHub + https://github.com/openhab/openhab-distro/issues + - - UTF-8 - UTF-8 + + + jfrog-release + ${oh.repo.distBaseUrl}/libs-release-local + + + jfrog + ${oh.repo.snapshotBaseUrl}/libs-snapshot-local + + - ${parsedVersion.majorVersion}.${parsedVersion.minorVersion} + + UTF-8 + UTF-8 - 4.2.0-SNAPSHOT - 4.2.0-SNAPSHOT + ${parsedVersion.majorVersion}.${parsedVersion.minorVersion} - 4.4.4 + 4.2.0-SNAPSHOT + 4.2.0-SNAPSHOT - 17 - ${oh.java.version} - ${oh.java.version} + 4.4.4 - 0.15.0 - 2.38.0 - - 4.25 - 4.21.0 - + 17 + ${oh.java.version} + ${oh.java.version} - - features - distributions - + 0.15.0 + 2.38.0 + + 4.25 + 4.21.0 + - - - - - org.apache.karaf.tooling - karaf-maven-plugin - ${karaf.version} - true - - - org.apache.maven.plugins - maven-enforcer-plugin - 3.4.0 - - - org.apache.maven.plugins - maven-assembly-plugin - 3.6.0 - - - org.apache.maven.plugins - maven-compiler-plugin - 3.11.0 - - - org.apache.maven.plugins - maven-install-plugin - 3.1.1 - - - - true - - - - org.codehaus.mojo - build-helper-maven-plugin - 3.4.0 - - - com.mycila - license-maven-plugin - 4.2 - - ${basedir} - false - true - true - true - - JAVADOC_STYLE - JAVADOC_STYLE - xml-header-style - - true - - 2024 - - UTF-8 - - -
licenses/epl-2.0/header.txt
- - licenses/epl-2.0/xml-header-style.xml - - - **/distributions/**/*.groovy - - - target/** - **/pom.xml - -
-
-
- - - - check - - - -
- - com.github.ekryd.sortpom - sortpom-maven-plugin - 3.3.0 - - recommended_2008_06 - false - true - - - - sortpom-verify - - verify - - verify - - Stop - - - - - - com.diffplug.spotless - spotless-maven-plugin - ${spotless.version} - - - - - - pom.xml - - - XML - - openhab_wst_pom_file.prefs - - ${spotless.eclipse.wtp.version} - - - - - - - - - org.openhab.tools - openhab-codestyle - ${sat.version} - - - - - codestyle_check - - check - - initialize - - - -
-
- - - org.apache.maven.plugins - maven-enforcer-plugin - - - enforce-java - - enforce - - - - - [17.0,18.0) - - - - - - - - org.codehaus.mojo - build-helper-maven-plugin - - - parse-version - - parse-version - - - - - - com.github.ekryd.sortpom - sortpom-maven-plugin - - - com.diffplug.spotless - spotless-maven-plugin - - -
+ + + + true + never + + + false + + jfrog + Artifactory Repository for openHAB + https://openhab.jfrog.io/artifactory/libs-3rdparty-local + + - - - jfrog - Artifactory Repository for openHAB - https://openhab.jfrog.io/artifactory/libs-3rdparty-local - - true - never - - - false - - - - - - - snapshotbuild - - - !release - - - - - local build - - ${oh.repo.releaseBaseUrl}/libs-snapshot - @snapshots - - - - releasebuild - - - release - - + + + + + org.apache.karaf.tooling + karaf-maven-plugin + ${karaf.version} + true + + + org.apache.maven.plugins + maven-enforcer-plugin + 3.4.0 + + + org.apache.maven.plugins + maven-assembly-plugin + 3.6.0 + + + org.apache.maven.plugins + maven-compiler-plugin + 3.11.0 + + + org.apache.maven.plugins + maven-install-plugin + 3.1.1 + + + + true + + + + org.codehaus.mojo + build-helper-maven-plugin + 3.4.0 + + + com.mycila + license-maven-plugin + 4.2 + + ${basedir} + false + true + true + true + + JAVADOC_STYLE + JAVADOC_STYLE + xml-header-style + + true - Release Build - ${oh.repo.releaseBaseUrl}/libs-release - + 2024 - - - milestonebuild - - - milestone - - - - Milestone Build - ${oh.repo.releaseBaseUrl}/libs-milestone - - - - + UTF-8 + + +
licenses/epl-2.0/header.txt
+ + licenses/epl-2.0/xml-header-style.xml + + + **/distributions/**/*.groovy + + + target/** + **/pom.xml + +
+
+ + + + + check + + + + + + com.github.ekryd.sortpom + sortpom-maven-plugin + 3.3.0 + + recommended_2008_06 + false + true + + + + sortpom-verify + + verify + + verify + + Stop + + + + + + com.diffplug.spotless + spotless-maven-plugin + ${spotless.version} + + + + + + pom.xml + + + XML + + openhab_wst_pom_file.prefs + + ${spotless.eclipse.wtp.version} + + + + + + + + + org.openhab.tools + openhab-codestyle + ${sat.version} + + + + + codestyle_check + + check + + initialize + + + + + + + + org.apache.maven.plugins + maven-enforcer-plugin + + + enforce-java + + enforce + + + + + [17.0,18.0) + + + + + + + + org.codehaus.mojo + build-helper-maven-plugin + + + parse-version + + parse-version + + + + + + com.github.ekryd.sortpom + sortpom-maven-plugin + + + com.diffplug.spotless + spotless-maven-plugin + + + + + + + snapshotbuild + + + !release + + + + - local build - + ${oh.repo.releaseBaseUrl}/libs-snapshot + @snapshots + + + + releasebuild + + + release + + + + Release Build + ${oh.repo.releaseBaseUrl}/libs-release + + + + + milestonebuild + + + milestone + + + + Milestone Build + ${oh.repo.releaseBaseUrl}/libs-milestone + + + +