Fix DateTimeType tests
#17764
Merged
Fix DateTimeType tests
#17764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
jlaur
requested review from
kaikreuzer,
holgerfriedrich,
Andy2003 and
lujop
as code owners
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors a few tests that assume the time-zone being put into a
DateTimeTypewill be the same as returned fromgetZonedDateTime()or used byformat(). Also fixes a few tests mixing UTC and system time-zone.These assumptions are still valid now, but if openhab/openhab-core#3583 is merged, they no longer will be. Therefore, this PR needs to be merged at latest at the same time to not break the build, but can be merged already now. Verifying these assumptions in addon tests provide no real value - this belongs to the core tests related to
DateTimeType.Prerequisite for openhab/openhab-core#3583
Also related to #17725 which simplifies
DateTimeTypelogic if openhab/openhab-core#3583 is merged