Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMIRNOFF: Remove details not part of the specification #49

Open
mattwthompson opened this issue Mar 2, 2023 · 0 comments
Open

SMIRNOFF: Remove details not part of the specification #49

mattwthompson opened this issue Mar 2, 2023 · 0 comments

Comments

@mattwthompson
Copy link
Member

There are a number of promises made and discussions of future work in the specification.

We are considering supporting JSON, MessagePack, YAML, and TOML representations as well.

Common defaults are defined, but the goal is to eventually allow these to be overridden by alternative choices or even algebraic expressions in the future, once more molecular simulation packages support general expressions.

... future extensions to the specification will support point multipoles, point polarizable dipoles, Drude oscillators, charge equilibration methods, and so on.

Support for other Lennard-Jones mixing schemes will be added later: Waldman-Hagler, Fender-Halsey, Kong, Tang-Toennies, Pena, Hudson-McCoubrey, Sikora.

Later revisions will add support for additional potential types (e.g., Buckingham-exp-6), as well as the ability to support arbitrary algebraic functional forms

Later revisions will also provide support for special interactions using the <AtomPair> tag

Later additions will add restrained electrostatic potential fitting (RESP) capabilities.

Later revisions will add support for additional potential types and the ability to support arbitrary algebraic functional forms. If the potential attribute is omitted, it defaults to harmonic.

Some other details are now out of date

Allowed values for units are given in simtk.unit (though in the future this may change to the more widely-used Python pint library).

or simply marked TODO

Add link to complete open specification of OEAroModel_MDL aromaticity model.

Should we have a separate <Metadata> or <Provenance> section that users can add whatever they want to?

or were nascent ideas that have not made it in and likely will not in the near future

Future additions will provide options for intelligently fragmenting large molecules and biopolymers, as well as a capping attribute to specify how fragments with dangling bonds are to be capped to allow these groups to be charged.

None of these should be in this or any specification. It should be about what is supported and how to implement those things. Until extensions are made, they should not be dangled as a carrot. (There are other ways to communicate this now that the organization is larger - roadmaps, user-facing documentation, etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant