Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product page: can we remove the Pull to refresh? #5948

Closed
g123k opened this issue Nov 27, 2024 · 2 comments
Closed

Product page: can we remove the Pull to refresh? #5948

g123k opened this issue Nov 27, 2024 · 2 comments

Comments

@g123k
Copy link
Collaborator

g123k commented Nov 27, 2024

Hi everyone!

Now that we have #5947 and that the future design of the product page won't allow swiping to refresh, is-it OK to get rid of this feature?

Or do we wait for the "POC"'s design?

@teolemon
Copy link
Member

teolemon commented Nov 27, 2024

Will there be a way to force refresh in some other way ?
Typically I have to refresh:

  • language change
  • server side changes

Will we refresh on slideup ?

I might not be your typical user.

@g123k
Copy link
Collaborator Author

g123k commented Nov 29, 2024

With the new design, that's impossible to implement, as the slide-up action is used to scroll.
So we keep it at least for this version, but we will be forced to remove it definitively.

@g123k g123k closed this as completed Nov 29, 2024
@github-project-automation github-project-automation bot moved this from 💬 To discuss and validate to 🎊 Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants