Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing warnings in PHP template #231

Merged
merged 1 commit into from
Dec 5, 2020
Merged

Fixing warnings in PHP template #231

merged 1 commit into from
Dec 5, 2020

Conversation

spekulatius
Copy link
Contributor

@spekulatius spekulatius commented Dec 1, 2020

Description

This fixes a few warning you get when using the PHP template:

  • naming convention (missing /) which will become an error with composer v2: Deprecation warning: Your package name function-php7.2 is invalid, it should have a vendor name, a forward slash, and a package name. The vendor and package name can be words separated by -, . or _. The complete name should match "^[a-z0-9]([_.-]?[a-z0-9]+)*/[a-z0-9](([_.]?|-{0,2})[a-z0-9]+)*$". Make sure you fix this as Composer 2.0 will error.
  • missing license

Motivation and Context

To avoid fixing every time.

How Has This Been Tested?

  • cd into folder
  • composer validate

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Version change (see: Impact to existing users)

Impact to existing users

As a template it shouldn't affect any existing users.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Peter Thaleikis <peter.thaleikis@gmail.com>
@derek derek bot added the new-contributor label Dec 1, 2020
@spekulatius
Copy link
Contributor Author

Hey @alexellis

just following to see what your take on this is? Pretty small change without larger implications afaik.

Cheers,
Peter

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis alexellis merged commit 2232e95 into openfaas:master Dec 5, 2020
@alexellis
Copy link
Member

Thank you for your PR and for being a user of openfaas. Please take a look at our new guide on Getting the most out of OpenFaaS as an end-user

@spekulatius
Copy link
Contributor Author

Thanks @alexellis. I'll check it out later on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants