shfmt and shellcheck compliance

[ionrover2]

This is really not a functional change at all.

This is a commonly used and referenced script. I just ran shfmt and shellcheck against it and resolved issues.

Description

slight formatting consistency and shellcheck remediation

Motivation and Context

This change honestly solves nothing. it just makes a commonly used shell script more consistent.

How Has This Been Tested?

yes, I was able to install on a clean multipass instance as one normally would with no issue.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Commits:

• I've read the CONTRIBUTION guide
• My commit message has a body and describe how this was tested and why it is required.
• I have signed-off my commits with git commit -s for the Developer Certificate of Origin (DCO)

Code:

• My code follows the code style of this project.
• I have added tests to cover my changes.

Docs:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.

[derek]

Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project.

Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken.

💡 Shall we fix this?

This will only take a few moments.

First, clone your fork and checkout this branch using the git CLI.

Next, set up your real name and email address:

git config --global user.name "Your Full Name"
git config --global user.email "you@domain.com"

Finally, run one of these commands to add the "Signed-off-by" line to your commits.

If you only have one commit so far then run: git commit --amend --signoff and then git push --force.
If you have multiple commits, watch this video.

Check that the message has been added properly by running "git log".

[alexellis]

This syntax does not look right?

[ionrover2]

I agree is looks funky, but removing the parens fixes the SC2091 warning in shellcheck and it still evaluates the same.

[alexellis]

I am not a shellcheck user so this doesn't bother me. I prefer the clarity we had originally.

[alexellis]

I'd be fine with this change being added.

[alexellis]

Would you be interested in coming to our weekly call to talk about how you're using faasd?

https://docs.openfaas.com/community/