Skip to content
This repository has been archived by the owner on Feb 4, 2020. It is now read-only.

Refactor into ES6 class, add more tests and update docs #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

developius
Copy link

Signed-off-by: Finnian Anderson get@finnian.io

This converts the openfaas package into an ES6 class, adds more tests and updates the documentation accordingly. It also removes the bluebird dependency in favour of native promises.

The reason for the refactor was to add support for basic auth and other configuration options as outlined in austinfrey/node-openfaas#5. The options are now proxied through to got and by extension http.request, allowing much finer-grained configuration with sane defaults.

Signed-off-by: Finnian Anderson <get@finnian.io>
@alexellis
Copy link
Member

This needs rebasing and cannot be merged right now.

There may have been valid reasons for using bluebird such as compatibility with the serverless framework. Please look into this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants