Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

student.html has no translations; needs expression_filter to be "h" #152

Open
OmarIthawi opened this issue Mar 30, 2021 · 2 comments
Open

Comments

@OmarIthawi
Copy link
Member

I just noticed that the student.html template needs an update. Here's the few problems I could spot in:

  • It doesn't specifies <%page expression_filter="h"/>, which is needed for security
  • It makes no use of gettext for translation, which is weird since it does have a ## Translators: ... note
  • It's in Mako and could be converted to Django templates

The lines below are related to the issue:

https://github.com/edx/xblock-lti-consumer/blob/2fd330f8a62bc2fcc4951d546db5ca4920a5c1ec/lti_consumer/templates/html/student.html#L1-L4

@OmarIthawi OmarIthawi changed the title student.html has no translations and needs to have a default escape (h) filter student.html has no translations and needs to have a default expression_filter to be "h" Mar 30, 2021
@OmarIthawi OmarIthawi changed the title student.html has no translations and needs to have a default expression_filter to be "h" student.html has no translations; needs expression_filter to be "h" Mar 30, 2021
@giovannicimolin
Copy link
Contributor

giovannicimolin commented Oct 19, 2021

@OmarIthawi I'm going to take a stab at converting this page to a Django template and fix the translations as part of my core contributor role.

@OmarIthawi
Copy link
Member Author

Thank you @giovannicimolin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

2 participants