-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] fix: show skeleton while loading src in CardImageCap (hook) #2846
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @khudym! When this pull request is ready, tag your edX technical lead. |
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
fix: use ref for image
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2846 +/- ##
===========================================
+ Coverage 0 92.83% +92.83%
===========================================
Files 0 238 +238
Lines 0 4272 +4272
Branches 0 1033 +1033
===========================================
+ Hits 0 3966 +3966
- Misses 0 302 +302
- Partials 0 4 +4 ☔ View full report in Codecov by Sentry. |
Description
issue with the fact that the markup jumps when loading a picture.
The CardImageCap component will display the Skeleton if Contexts isLoading=true (but this applies to the data itself), if isLoading=false, the img tag with the received data will be rendered, and the actual loading of the image will begin.
Couple solutions:
Issue#2480
Deploy Preview
deploy-preview-2846
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist