Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace WatchOutline with Notifications #1509 #1510

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jciasenza
Copy link
Contributor

#1509

What changed?
Replace WathOutline icon with notifications
it looks more aesthetic

image

Screenshot from 2024-11-01 15-43-47

And Testing OK

If something needs to be modified, let me know, thank you!!!
Atte
Juan Carlos (Aulasneo)

Developer Checklist

Test suites passing
Documentation and test plan updated, if applicable
Received code-owner approving review

@openedx-webhooks
Copy link

Thanks for the pull request, @jciasenza!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/committers-frontend-app-learning. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.25%. Comparing base (c20c767) to head (0b04c50).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1510   +/-   ##
=======================================
  Coverage   89.25%   89.25%           
=======================================
  Files         318      318           
  Lines        5563     5563           
  Branches     1379     1379           
=======================================
  Hits         4965     4965           
+ Misses        583      582    -1     
- Partials       15       16    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itsjeyd
Copy link

itsjeyd commented Nov 7, 2024

@jciasenza Thank you for this contribution!

We have a green build here so I'm marking this PR as ready for review. (Let us know if you had plans to continue working on the changes before putting them up for review, though.)

@itsjeyd itsjeyd added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Nov 7, 2024
@itsjeyd itsjeyd requested a review from a team November 7, 2024 09:26
@jciasenza
Copy link
Contributor Author

itsjeyd I think it would be ready so they can merge it

@bradenmacdonald
Copy link
Contributor

@jciasenza Thank you for the contribution. @itsjeyd This looks great from my perspective but shouldn't we get a product +1 since it's a UX change?

@angonz
Copy link

angonz commented Nov 8, 2024

@jciasenza Thank you for the contribution. @itsjeyd This looks great from my perspective but shouldn't we get a product +1 since it's a UX change?

I asked Chelsea in the original issue to look at it.

@itsjeyd
Copy link

itsjeyd commented Nov 14, 2024

@bradenmacdonald @jciasenza Sounds good re: getting product approval.

@itsjeyd itsjeyd added product review PR requires product review before merging and removed waiting for eng review PR is ready for review. Review and merge it, or suggest changes. labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U product review PR requires product review before merging
Projects
Status: Product Review
Development

Successfully merging this pull request may close these issues.

5 participants