-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Replace WatchOutline with Notifications #1509 #1510
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @jciasenza! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1510 +/- ##
=======================================
Coverage 89.25% 89.25%
=======================================
Files 318 318
Lines 5563 5563
Branches 1379 1379
=======================================
Hits 4965 4965
+ Misses 583 582 -1
- Partials 15 16 +1 ☔ View full report in Codecov by Sentry. |
@jciasenza Thank you for this contribution! We have a green build here so I'm marking this PR as ready for review. (Let us know if you had plans to continue working on the changes before putting them up for review, though.) |
itsjeyd I think it would be ready so they can merge it |
@jciasenza Thank you for the contribution. @itsjeyd This looks great from my perspective but shouldn't we get a product +1 since it's a UX change? |
I asked Chelsea in the original issue to look at it. |
@bradenmacdonald @jciasenza Sounds good re: getting product approval. |
#1509
What changed?
Replace WathOutline icon with notifications
it looks more aesthetic
And Testing OK
If something needs to be modified, let me know, thank you!!!
Atte
Juan Carlos (Aulasneo)
Developer Checklist
Test suites passing
Documentation and test plan updated, if applicable
Received code-owner approving review