Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Closing editor without changes still prompts warning #1388

Open
jmakowski1123 opened this issue Oct 16, 2024 · 4 comments · Fixed by #1444
Open

Bug: Closing editor without changes still prompts warning #1388

jmakowski1123 opened this issue Oct 16, 2024 · 4 comments · Fixed by #1444
Assignees
Labels
bug Report of or fix for something that isn't working as intended

Comments

@jmakowski1123
Copy link

When opening a problem or text component for editing, then closing it without making any edits, I notice that there is still a confirmation prompt. If no changes have been made, is it possible to allow the user to exit the modal without that confirmation?

@jmakowski1123 jmakowski1123 converted this from a draft issue Oct 16, 2024
@navinkarkera navinkarkera self-assigned this Oct 25, 2024
@bradenmacdonald bradenmacdonald added the bug Report of or fix for something that isn't working as intended label Oct 31, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Libraries Overhaul Nov 4, 2024
@bradenmacdonald bradenmacdonald moved this from Done to Ready for AC testing in Libraries Overhaul Nov 4, 2024
@pomegranited pomegranited reopened this Nov 7, 2024
@pomegranited
Copy link
Contributor

@jmakowski1123 @lizc577 @sdaitzman @marcotuts This is ready for AC testing on the sandbox

@jmakowski1123
Copy link
Author

This fix is working with text and problem blocks, but not with video blocks. When I either 1) open a new video or 2) edit an existing video, and close without making changes, I still see the message. See below for a few links

https://app.tagging-preview.staging.do.opencraft.hosting/course-authoring/library/lib:OpenCraft:TL/components

https://app.tagging-preview.staging.do.opencraft.hosting/course-authoring/library/lib:OpenCraft:TL/components

@navinkarkera
Copy link
Contributor

@jmakowski1123 Yes, apologies for not mentioning it here.

I have not implemented this functionality for video editors as it is a bit more involved than problem and text blocks as there are many fields. So it shows the confirmation box regardless of any change. I wanted to confirm before spending time for the video editor as the issue only mentions problem and text blocks.

@ChrisChV
Copy link
Contributor

@jmakowski1123 Is it okay to move it to Done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended
Projects
Status: Ready for AC testing
Development

Successfully merging a pull request may close this issue.

5 participants