Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sqlite db update action in repo health job #405

Closed
2 tasks done
UsamaSadiq opened this issue Jul 25, 2023 · 5 comments
Closed
2 tasks done

Fix sqlite db update action in repo health job #405

UsamaSadiq opened this issue Jul 25, 2023 · 5 comments
Assignees

Comments

@UsamaSadiq
Copy link
Member

UsamaSadiq commented Jul 25, 2023

Description

The issue edx/edx-arch-experiments#66 updated the repo health script to run successfully with GitHub Actions.
The sqlite db update step was failing with GitHub Actions workflow which needs to be investigated and resolved.

TODO

Investigate the sqlite failure by uncommenting the sqlite update logic in the repo_health_dashboard.py file.

  • Fix the sqlite check to work successfully
  • Extract the sqlite check to the repo health workflow so it can be saved as an artifact of the workflow run.
@zubairshakoorarbisoft
Copy link
Contributor

@UsamaSadiq I can't found this file repo_health_dashboard.py

@UsamaSadiq
Copy link
Member Author

Updated the link for the file in the description as well. You can see the respective code lines at https://github.com/openedx/edx-repo-health/blob/master/repo_health_dashboard/repo_health_dashboard.py#L92

@iamsobanjaved iamsobanjaved moved this from Todo to In Progress in Arbi-BOM Aug 15, 2023
@iamsobanjaved iamsobanjaved moved this from In Progress to Todo in Arbi-BOM Aug 25, 2023
@zubairshakoorarbisoft zubairshakoorarbisoft self-assigned this Oct 11, 2023
@UsamaSadiq
Copy link
Member Author

Created the first PR #423 to fix this issue.

@iamsobanjaved iamsobanjaved moved this from Todo to Author Team Review in Arbi-BOM Oct 19, 2023
@UsamaSadiq UsamaSadiq moved this from Author Team Review to In Progress in Arbi-BOM Oct 24, 2023
@UsamaSadiq
Copy link
Member Author

Approach for the solution:

  • Updated the repo-health-job.yml bash script to exclude the generation of the sqldb file
  • Created another bash script repo-health-artifact.yml exclusively for the generation of sqldb file
  • Updated the repo health job workflow to add a new job which gets triggered after the data collection has successfully being completed.
  • The new job then runs the sqldb generation script and uploads the generated db file as an artifact to the workflow.

@UsamaSadiq UsamaSadiq moved this from In Progress to Author Team Review in Arbi-BOM Oct 24, 2023
@UsamaSadiq UsamaSadiq moved this from Author Team Review to Owner Review in Arbi-BOM Oct 30, 2023
@UsamaSadiq UsamaSadiq moved this from Owner Review to Author Team Review in Arbi-BOM Dec 4, 2023
@UsamaSadiq
Copy link
Member Author

Updated approach:

  • Removed the new job (triggering step for artifact script execution) in the reusable workflow
  • Tested the script execution using a custom build trigger from the forked reusable workflow
  • Once the reusable workflow PR is merged, the scheduled repo health job will also start generating the sqlite db as artifact on each build.

@UsamaSadiq UsamaSadiq moved this from Author Team Review to Owner Review in Arbi-BOM Dec 14, 2023
@github-project-automation github-project-automation bot moved this from Owner Review to Done in Arbi-BOM Dec 15, 2023
@jristau1984 jristau1984 moved this from Done to Done - Long Term Storage in Arbi-BOM Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants