Dockerfile: merges manifests builder stages to one #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @bartoszmajsak @zdtsw |
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## incubation #1381 +/- ##
=============================================
Coverage ? 18.91%
=============================================
Files ? 30
Lines ? 3399
Branches ? 0
=============================================
Hits ? 643
Misses ? 2687
Partials ? 69 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
zdtsw
approved these changes
Nov 19, 2024
We can combine two build stages into one, as there is no need to always build both images (not done by podman) to only then decide from which one we want to copy manifests to the target image. Instead manifests stage will either copy local manifests or fetches using the script based on USE_LOCAL argument. Move USE_LOCAL and OVERWIRTE_MANIFESTS args under FROM since args have scope of the FROM they are declared in. It requires opt/manifests directory to exist, but since it's a part of git repo, it's fine. Original patch from: Bartosz Majsak <bartosz.majsak@gmail.com> [1] [1] opendatahub-io#773 Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
ykaliuta
force-pushed
the
dockerfile-manifests
branch
from
6224240
to
0cc649f
Compare
|
rebased |
|
/retest-required |
|
@zdtsw sorry for disturbing, but could you recheck it after rebase? |
zdtsw
approved these changes
Nov 20, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit c1671ab
into
opendatahub-io:incubation
10 checks passed
zdtsw
pushed a commit
to zdtsw-forking/opendatahub-operator
that referenced
this pull request
Nov 28, 2024
We can combine two build stages into one, as there is no need to always build both images (not done by podman) to only then decide from which one we want to copy manifests to the target image. Instead manifests stage will either copy local manifests or fetches using the script based on USE_LOCAL argument. Move USE_LOCAL and OVERWIRTE_MANIFESTS args under FROM since args have scope of the FROM they are declared in. It requires opt/manifests directory to exist, but since it's a part of git repo, it's fine. Original patch from: Bartosz Majsak <bartosz.majsak@gmail.com> [1] [1] opendatahub-io#773 Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> (cherry picked from commit c1671ab)
zdtsw
pushed a commit
to zdtsw-forking/opendatahub-operator
that referenced
this pull request
Nov 29, 2024
We can combine two build stages into one, as there is no need to always build both images (not done by podman) to only then decide from which one we want to copy manifests to the target image. Instead manifests stage will either copy local manifests or fetches using the script based on USE_LOCAL argument. Move USE_LOCAL and OVERWIRTE_MANIFESTS args under FROM since args have scope of the FROM they are declared in. It requires opt/manifests directory to exist, but since it's a part of git repo, it's fine. Original patch from: Bartosz Majsak <bartosz.majsak@gmail.com> [1] [1] opendatahub-io#773 Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> (cherry picked from commit c1671ab)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can combine two build stages into one, as there is no need to always build both images (not done by podman) to only then decide from which one we want to copy manifests to the target image. Instead manifests stage will either copy local manifests or fetches using the script based on USE_LOCAL argument.
Move USE_LOCAL and OVERWIRTE_MANIFESTS args under FROM since args have scope of the FROM they are declared in.
It requires opt/manifests directory to exist, but since it's a part of git repo, it's fine.
Original patch from: Bartosz Majsak bartosz.majsak@gmail.com [1]
[1] #773
Description
How Has This Been Tested?
Screenshot or short clip
Merge criteria