Skip to content

Commit

Permalink
set clusterDomain as ingressDomain for Kserve RawDeployment Routes
Browse files Browse the repository at this point in the history
Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
  • Loading branch information
VedantMahabaleshwarkar committed Sep 12, 2024
1 parent 294cc1e commit 69f0236
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions components/kserve/kserve_config_handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,12 @@ func (k *Kserve) setDefaultDeploymentMode(ctx context.Context, cli client.Client
if err = json.Unmarshal([]byte(inferenceServiceConfigMap.Data["ingress"]), &ingressData); err != nil {
return fmt.Errorf("error retrieving value for key 'ingress' from configmap %s. %w", KserveConfigMapName, err)
}
clusterDomain, err := cluster.GetDomain(ctx, cli)
if err != nil {
return fmt.Errorf("error retrieving cluster domain %s. %w", KserveConfigMapName, err)
}
if defaultmode == RawDeployment {
ingressData["disableIngressCreation"] = true
} else {
ingressData["disableIngressCreation"] = false
ingressData["ingressDomain"] = clusterDomain
}
ingressDataBytes, err := json.MarshalIndent(ingressData, "", " ")
if err != nil {
Expand Down

0 comments on commit 69f0236

Please sign in to comment.