RHOAIENG-16202: Sync main into v1.9-branch #470
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
RHOAIENG-15743: fix(odh-nbc): trim ca-bundle certData to avoid logging scary messages
Update gha to update makefile-vars.mk external file
…e tests (#461) This is in accordance with the recommendations in the Kubebuilder Book. https://book.kubebuilder.io/cronjob-tutorial/writing-tests
* Update sync workflow to hadle specific conflicts * Externalize KF_TAG variable to dedicated file outside of the makefile * Update makefile logic handling
…iable (#462) This is a nasty Go gotcha, and we aren't the first to have trouble with it https://temporal.io/blog/go-shadowing-bad-choices#the-bug
…envtest (#464) * RHOAIENG-15772: tests(odh-nbc): disable graceful shutdown period for envtest There is no benefit to doing graceful shutdown. We don't assert anything about the shutdown process, so it is best to be done with it quickly, so that we don't waste time and also avoid some meaningless log messages the shutdown may print out. * fixup also pass in test context
…efore stopping envtest (#463) Otherwise, there will be some errors printed in the output. It was not breaking anything, but it was unpleasant to look at. The notebook-controller does not seem to be suffering from this. Probably because it does not use a webhook. Example of the error message that's prevented by this ``` 2024-11-17T20:19:57+01:00 ERROR controller-runtime.certwatcher error re-reading certificate {"error": "open /var/folders/f1/3m518k5d34l72v_9nqyjzqm80000gn/T/envtest-serving-certs-737480808/tls.crt: no such file or directory"} ```
… request (#450) * RHOAIENG-15772: tests(odh-nbc): write envtest kubeconfig to disk upon request This helps with debugging because it's then possible to do e.g. ``` KUBECONFIG=/tmp/envtest.kubeconfig k9s ``` and investigate the cluster while the test is paused on a breakpoint. * fixup docs and logging * fixup move user creation as early as possible, and explain test verbosity * Update components/odh-notebook-controller/README.md Co-authored-by: Jan Stourac <jstourac@redhat.com> --------- Co-authored-by: Jan Stourac <jstourac@redhat.com>
… disk upon request (#451) * RHOAIENG-15772: tests(odh-nbc): write auditlogs from envtest tests to disk upon request This helps with debugging because it's then possible to do e.g. ``` cat /tmp/audit.log | jq | ... ``` and investigate what happened when a test was running. * fixup logging and order and few comments * fixup readme and tweaks
… messages (#454) Now it will be possible to see why the check failed, instead of getting the meaningless ``` Expected <bool>: false to be true ```
* [Fix] update bash scripts for E2E tests run to propagate failures We haven't been propagating the test failures in our E2E CI jobs because we weren't checking for the return codes of the commands run in the bash scripts. Also, this fixes setup* targets in Makefile so that expected images are deployed to the testing cluster. * asdf
…d not update it with digest updater from now on (#468)
|
Hi @github-actions[bot]. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
jiridanek
changed the title
|
Niahhh what is happening again with the e2e tests? I have the same on this PR #469 where there are no changes on the code base |
|
Yes, Jan announced this on standup, no? Tests were broken since forever, the change in #433 now makes the failure visible. |
|
/override ci/prow/odh-notebook-controller-e2e |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/odh-notebook-controller-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
deleted the
sync__main__v1.9-branch__20241126102910
branch
https://issues.redhat.com/browse/RHOAIENG-16202
🤖 This is an automated PR