Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-15748: chore(release): set the main tag to main, so we need not update it with digest updater from now on #468

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

jiridanek
Copy link
Member

https://issues.redhat.com/browse/RHOAIENG-15748

Follow-up to

Description

image

https://docs.google.com/document/d/1R1zPFKI4-HQY9SeJYa2erSnzr5YNdEU497CdOgni7AY/edit?tab=t.0#heading=h.p8a8iq2tou22

How Has This Been Tested?

Images with main tag are present and can be used

podman pull --platform=linux/amd64 quay.io/opendatahub/kubeflow-notebook-controller:main
Trying to pull quay.io/opendatahub/kubeflow-notebook-controller:main...
Getting image source signatures
Copying blob sha256:bb4c96ca6d403d756b0d1fa420b6ade5ab46035a46451db44f1abff5b200b345
Copying blob sha256:e0348fdb2685077d22116d294a90a253709aba78815882a57fcc536b22dcae2f
Copying config sha256:dfab4f088ac5d5587543216d61a0969a63a0c0f148c8a9782b2be221eaf28f6b
Writing manifest to image destination
dfab4f088ac5d5587543216d61a0969a63a0c0f148c8a9782b2be221eaf28f6b
podman pull --platform=linux/amd64 quay.io/opendatahub/odh-notebook-controller:main
Trying to pull quay.io/opendatahub/odh-notebook-controller:main...
Getting image source signatures
Copying blob sha256:84f1c1f659dd19766fea787ec33bcf66ff5ad1b78be4f6f7eaf73276ee0466e3
Copying blob sha256:e0348fdb2685077d22116d294a90a253709aba78815882a57fcc536b22dcae2f
Copying config sha256:d7ca01df108e912016aa9ce24d9013fd01a1ab323e7674939d3c2451a6cea92a
Writing manifest to image destination
d7ca01df108e912016aa9ce24d9013fd01a1ab323e7674939d3c2451a6cea92a

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

…d not update it with digest updater from now on
Copy link
Member

@jstourac jstourac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jiridanek

This comment was marked as outdated.

This comment was marked as outdated.

@atheo89
Copy link
Member

atheo89 commented Nov 25, 2024

/lgtm

@jiridanek
Copy link
Member Author

/override ci/prow/odh-notebook-controller-e2e

Copy link

openshift-ci bot commented Nov 25, 2024

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/odh-notebook-controller-e2e

In response to this:

/override ci/prow/odh-notebook-controller-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit f1be2a4 into opendatahub-io:main Nov 25, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants