Skip to content

Commit

Permalink
[Fix] kustomize package version revision
Browse files Browse the repository at this point in the history
This is a followup of #391 (1b2dd4f).

Without this, we can see the following failure during the e2e tests
execution:
```
make run-ci-e2e-tests
...
GOBIN=/home/jstourac/workspace/rhosai/odh/kubeflow/components/odh-notebook-controller/bin go install sigs.k8s.io/kustomize/v3/cmd/kustomize@v5.0.2
go: sigs.k8s.io/kustomize/v3/cmd/kustomize@v5.0.2: sigs.k8s.io/kustomize/v3/cmd/kustomize@v5.0.2: invalid version: unknown revision v3/cmd/kustomize/v5.0.2
make[1]: *** [Makefile:243: kustomize] Error 1
...
```
This caused that all e2e tests failed. After this fix, some e2e tests
pass. The other seem to fail on a problem unrelated to this one.
  • Loading branch information
jstourac committed Nov 8, 2024
1 parent 0f3c742 commit 8dba731
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion components/notebook-controller/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ controller-gen: ## Download controller-gen locally if necessary.
KUSTOMIZE = $(shell pwd)/bin/kustomize
.PHONY: kustomize
kustomize: ## Download kustomize locally if necessary.
$(call go-get-tool,$(KUSTOMIZE),sigs.k8s.io/kustomize/v3/cmd/kustomize@v5.0.2)
$(call go-get-tool,$(KUSTOMIZE),sigs.k8s.io/kustomize/kustomize/v5@v5.0.2)

ENVTEST = $(shell pwd)/bin/setup-envtest
ENVTEST_VERSION?=v0.0.0-20240923090159-236e448db12c
Expand Down
2 changes: 1 addition & 1 deletion components/odh-notebook-controller/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ controller-gen: ## Download controller-gen locally if necessary.
KUSTOMIZE = $(LOCALBIN)/kustomize
.PHONY: kustomize
kustomize: ## Download kustomize locally if necessary.
GOBIN=$(LOCALBIN) go install sigs.k8s.io/kustomize/v3/cmd/kustomize@v5.0.2
GOBIN=$(LOCALBIN) go install sigs.k8s.io/kustomize/kustomize/v5@v5.0.2

ENVTEST = $(LOCALBIN)/setup-envtest
.PHONY: envtest
Expand Down

0 comments on commit 8dba731

Please sign in to comment.