Do not save logs when RayJob status is missing #155
Conversation
| // Retrieve dashboard hostname | ||
| dashboard, err := test.Client().Route().RouteV1().Routes(namespace.Name).Get(test.Ctx(), dashboardRoute.Name, metav1.GetOptions{}) | ||
| test.Expect(err).NotTo(HaveOccurred()) | ||
| dashboardHostname := dashboard.Status.Ingress[0].Host |
There was a problem hiding this comment.
Maybe an if statement the checks the status would be better than commenting out the code?
There was a problem hiding this comment.
Thank you @astefanutti for good tip. I've created a function which checks if RayJob status is present first. If yes it saves the logs if not it will skip saving the log.
jiripetrlik
force-pushed
the
disable-logs
branch
from
c3a9ebe
to
8a1b33f
Compare
jiripetrlik
changed the title
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astefanutti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jiripetrlik: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
It is because of RHODS-12857. Utilities which save the logs require RayJob status which may not be available.