Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor how solver parameters are handled #2257

Open
rmtfleming opened this issue Apr 29, 2024 · 0 comments
Open

refactor how solver parameters are handled #2257

rmtfleming opened this issue Apr 29, 2024 · 0 comments

Comments

@rmtfleming
Copy link
Member

Passing non-solver specific parameters to a solver gives an error. But this approach to split parameter structures

[problemTypeParams, extraParams] = parseSolverParameters(problemType, varargin)

and use extraParams for the solver needs to be replaced with one where a single parameter structure is stripped of any non-solver specific parameters before. What is problemType specific is defined here
paramNames = getCobraSolverParamsOptionsForType(problemType)
but that changes over time, making it confusing what parameter is a solver, problem-type vs other type of parameter with the potential for the same parameter to be different in different parameter structures. Better to only have one parameter structure then strip that to the solver specific ones just before calling the solver. One strip function per solver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant