Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecs cloudwatch vs cloud-watch #92

Open
axel-nagel opened this issue Nov 22, 2024 · 2 comments
Open

ecs cloudwatch vs cloud-watch #92

axel-nagel opened this issue Nov 22, 2024 · 2 comments

Comments

@axel-nagel
Copy link

As far as I can see there is a mismatch between configuration documentation and code:

mind the "dash"

e.g.
proxy.ecs.enable-cloudwatch-group-prefix
https://www.shinyproxy.io/documentation/configuration/
vs.

cloudWatchGroupPrefix = environment.getProperty("proxy.ecs.cloud-watch-group-prefix", String.class, "/ecs/");

@LEDfan
Copy link
Member

LEDfan commented Nov 25, 2024

Hi, many thanks for opening this issue. I updated the documentation to fix this issue: https://www.shinyproxy.io/documentation/configuration/#ecs

Note that the proxy.ecs.enable-cloudwatch does not have a -, we will fix this inconsistency in the next release.

@axel-nagel
Copy link
Author

Hi,
many thanks to you for keeping up the good work here. If someone is already on it, it might be interesting to be able to set the log retention for the log groups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants