feat: Update metrics configuration patch #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaylareopelle
changed the title
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
|
Blocked by #1551 |
kaylareopelle
changed the title
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
kaylareopelle
force-pushed
the
update-configuration-patch
branch
from
86a9337
to
f0c7663
Compare
…variable The environment variable has options for: * console (default) * otlp * in-memory * none Like the Traces exporter, more than one exporter can be configured
kaylareopelle
force-pushed
the
update-configuration-patch
branch
from
f0c7663
to
8ec788b
Compare
kaylareopelle
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam and
robbkidd
as code owners
kaylareopelle
commented
Aug 27, 2024
metrics_sdk/lib/opentelemetry/sdk/metrics/configuration_patch.rb
Outdated
Show resolved
Hide resolved
mwear
approved these changes
Oct 11, 2024
* Default option is now OTLP * In-Memory option removed, it's not in the spec * PeriodicMetricReader added for both Console and OTLP exporters * Add the metrics OTLP exporter gem to the test gem group
kaylareopelle
commented
Oct 15, 2024
mwear
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the metrics configuration patch to match the functionality for traces in the
OpenTelemetry::SDK::Configurator.Once this PR is merged, the metric exporter can be automatically configured using the
OTLP_METRICS_EXPORTERenvironment variable.The environment variable has options for:
Like the Traces exporter, more than one exporter can be configured.
This draws a lot from the structure in: https://github.com/open-telemetry/opentelemetry-ruby/blob/main/sdk/lib/opentelemetry/sdk/configurator.rb
It intends to follow the specification: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/configuration/sdk-environment-variables.md?plain=1#L256