otelhttptrace: handle missing getconn hook without panic #5965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krantideep95
changed the title
krantideep95
force-pushed
the
httptrace-end-panic-with-tests
branch
2 times, most recently
from
657953b
to
bb96c05
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5965 +/- ##
=====================================
Coverage 65.7% 65.7%
=====================================
Files 204 204
Lines 13083 13085 +2
=====================================
+ Hits 8605 8609 +4
+ Misses 4215 4214 -1
+ Partials 263 262 -1
|
krantideep95
force-pushed
the
httptrace-end-panic-with-tests
branch
2 times, most recently
from
ad46607
to
1a053a4
Compare
|
Hey @dmathieu, sorry for the tag. Would you mind reviewing this Pull Request? Thanks! |
dmathieu
reviewed
Aug 20, 2024
instrumentation/net/http/httptrace/otelhttptrace/clienttrace_test.go
Outdated
Show resolved
Hide resolved
We have many reports that end() gets called without the span being defined in start() and causes a panic. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
krantideep95
force-pushed
the
httptrace-end-panic-with-tests
branch
3 times, most recently
from
1ee5129
to
7ecfc42
Compare
krantideep95
force-pushed
the
httptrace-end-panic-with-tests
branch
from
7ecfc42
to
6e6185e
Compare
dmathieu
approved these changes
Sep 11, 2024
dashpole
approved these changes
Sep 11, 2024
MrAlias
added a commit
that referenced
this pull request
Oct 14, 2024
### Added - The `Severitier` and `SeverityVar` types are added to `go.opentelemetry.io/contrib/processors/minsev` allowing dynamic configuration of the severity used by the `LogProcessor`. (#6116) - Move examples from `go.opentelemetry.io/otel` to this repository under `examples` directory. (#6158) - Support yaml/json struct tags for generated code in `go.opentelemetry.io/contrib/config`. (#5433) - Add support for parsing YAML configuration via `ParseYAML` in `go.opentelemetry.io/contrib/config`. (#5433) - Add support for temporality preference configuration in `go.opentelemetry.io/contrib/config`. (#5860) ### Changed - The function signature of `NewLogProcessor` in `go.opentelemetry.io/contrib/processors/minsev` has changed to accept the added `Severitier` interface instead of a `log.Severity`. (#6116) - Updated `go.opentelemetry.io/contrib/config` to use the [v0.3.0](https://github.com/open-telemetry/opentelemetry-configuration/releases/tag/v0.3.0) release of schema which includes backwards incompatible changes. (#6126) - `NewSDK` in `go.opentelemetry.io/contrib/config` now returns a no-op SDK if `disabled` is set to `true`. (#6185) - The deprecated `go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho` package has found a Code Owner. The package is no longer deprecated. (#6207) ### Fixed - Possible nil dereference panic in `go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace`. (#5965) - `logrus.Level` transformed to appropriate `log.Severity` in `go.opentelemetry.io/contrib/bridges/otellogrus`. (#6191) ### Removed - The `Minimum` field of the `LogProcessor` in `go.opentelemetry.io/contrib/processors/minsev` is removed. Use `NewLogProcessor` to configure this setting. (#6116) - The deprecated `go.opentelemetry.io/contrib/instrumentation/gopkg.in/macaron.v1/otelmacaron` package is removed. (#6186) - The deprecated `go.opentelemetry.io/contrib/samplers/aws/xray` package is removed. (#6187) --------- Co-authored-by: David Ashpole <dashpole@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fork of #5187 updated with main branch and tests, this PR adds nil dereference check for clientTracer.root in
end()when span events are used instead of sub spans