Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process.runtime.go.cgo.calls metric should be Counter #2648

Closed
vmihailenco opened this issue Aug 13, 2022 · 3 comments
Closed

process.runtime.go.cgo.calls metric should be Counter #2648

vmihailenco opened this issue Aug 13, 2022 · 3 comments

Comments

@vmihailenco
Copy link
Contributor

vmihailenco commented Aug 13, 2022

runtime.NumCgoCall() returns a monotonic number which never goes down so I guess it should be a Counter.

a587520 changed process.runtime.go.cgo.calls from Counter to UpDownCounter without providing a reason. Perhaps it was a typo?

@jmacd
Copy link
Contributor

jmacd commented Sep 7, 2022

Agreed. I want to retire the library producing this metric, however, see #2643 and plan on discussing this topic in the 9/8 Go SIG call.

@AkhigbeEromo
Copy link
Contributor

i have a question concerning this:

Has the library been retired @jmacd ?
If not, I would like to work on this issue @MrAlias

@MrAlias
Copy link
Contributor

MrAlias commented Oct 17, 2024

This appears to be stale. The runtime package was updated in #5780 and no longer contains this metric.

@MrAlias MrAlias closed this as not planned Won't fix, can't repro, duplicate, stale Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants