Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the detext to beta dataset preparer #1874

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

2019zhou
Copy link

@2019zhou 2019zhou commented Apr 23, 2023

Motivation

add the detext to beta dataset preparer

Modification

add the detext to the dataset_zoo and the add the DetextDetAnnParser

dataset_zoo/
├── detext
│ ├── metafile.yml
│ ├── textdet.py
│ ├── textrecog.py
│ └── textspotting.py

BC-breaking (Optional)

no

Use cases (Optional)

python tools/dataset_converters/prepare_dataset.py detext --task textdet --overwrite-cfg
python tools/dataset_converters/prepare_dataset.py detext --task textrecog --overwrite-cfg

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Apr 23, 2023

CLA assistant check
All committers have signed the CLA.

@OpenMMLab-Assistant-004

Hi @2019zhou !We are grateful for your efforts in helping improve mmocr open-source project during your personal time.

Welcome to join OpenMMLab Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA
If you have a WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)

Thank you again for your contribution❤

Copy link
Collaborator

@gaotongxiao gaotongxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It overall works great from my side, and there is some perspective to improve before we get it merged. :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As dataset preparer will generate this config, we can remove it from this PR. Same for configs/textrecog/base/datasets/detext.py and configs/textspotting/base/datasets/detext.py

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that DetextDetAnnParser is exactly the same as ICDARTxtTextDetAnnParser? In this case, this implementation can be removed, and we can use reuse ICDARTxtTextDetAnnParser in Detext's config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants