-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add the detext to beta dataset preparer #1874
base: main
Are you sure you want to change the base?
Conversation
Hi @2019zhou !We are grateful for your efforts in helping improve mmocr open-source project during your personal time. Welcome to join OpenMMLab Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA Thank you again for your contribution❤ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It overall works great from my side, and there is some perspective to improve before we get it merged. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As dataset preparer will generate this config, we can remove it from this PR. Same for configs/textrecog/base/datasets/detext.py and configs/textspotting/base/datasets/detext.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that DetextDetAnnParser
is exactly the same as ICDARTxtTextDetAnnParser
? In this case, this implementation can be removed, and we can use reuse ICDARTxtTextDetAnnParser
in Detext's config.
Motivation
add the detext to beta dataset preparer
Modification
add the detext to the dataset_zoo and the add the DetextDetAnnParser
dataset_zoo/
├── detext
│ ├── metafile.yml
│ ├── textdet.py
│ ├── textrecog.py
│ └── textspotting.py
BC-breaking (Optional)
no
Use cases (Optional)
Checklist
Before PR:
After PR: