-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support DreamFusion #1563
base: main
Are you sure you want to change the base?
Conversation
38dafeb
to
81de7ac
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1563 +/- ##
==========================================
- Coverage 82.23% 80.52% -1.72%
==========================================
Files 416 425 +9
Lines 27960 28747 +787
Branches 4374 4461 +87
==========================================
+ Hits 22994 23148 +154
- Misses 4026 4658 +632
- Partials 940 941 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
||
self.clamp_mode = clamp_mode | ||
self.white_back = white_back | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add occupancy grid transmittance estimator for spatial skipping. "nerfacc.OccGridEstimator(roi_aabb, resolution, levels)"
ray_start, | ||
ray_end, | ||
depth_resolution, | ||
perturb=self.training) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sampling with spatial skipping.
ray_indices, t_starts, t_ends = grid.sampling(rays_o, rays_d, render_step_size=1e-3)
t_mid = (t_starts + t_ends) / 2.0
sample_locs = rays_o[ray_indices] + t_mid * rays_d[ray_indices]
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Support Dreamfusion. Refers to https://github.com/ashawkey/stable-dreamfusion
Who can help? @ them here!
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:
After PR: