Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy probe-services v2 in production #2781

Open
ainghazal opened this issue Jul 19, 2024 · 3 comments
Open

deploy probe-services v2 in production #2781

ainghazal opened this issue Jul 19, 2024 · 3 comments
Labels
chore routine tasks that must be done, but require little active brain power triage

Comments

@ainghazal
Copy link

The openvpn experiment depends on the newer endpoint we deployed a few months ago in the staging backend. To be able to test the release candidates, we need to deploy the service in production.

@ainghazal ainghazal added bug Something isn't working triage chore routine tasks that must be done, but require little active brain power and removed bug Something isn't working labels Jul 19, 2024
@hellais
Copy link
Member

hellais commented Jul 24, 2024

For an MVP can we just hardcode some endpoints in the test that we know are going to be stable? I don't think it's realistic to assume probe services v2 will be in production by the rollout of the experiment.

@ainghazal
Copy link
Author

ainghazal commented Jul 24, 2024

  • there were a couple openvpn endpoints hardcoded; they were removed to ensure API can control switching off the experiment by delivering an empty list (possibly by country);
  • it's possible to re-add those default endpoints
  • the credentials problem remains unsolved; we cannot hardcode them in a production client (since they will expire); that was the reason that drove the VPN endpoint in the first place.

@ainghazal
Copy link
Author

ainghazal commented Jul 24, 2024

fwiw, the experimental card simply does not run the OpenVPN experiment if the API returns an error. So perhaps it's feasible to ship it and just enable the service whenever it's possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore routine tasks that must be done, but require little active brain power triage
Projects
None yet
Development

No branches or pull requests

2 participants