Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update Gradle and Android core dependencies #583

Merged
merged 7 commits into from
Sep 9, 2023

Conversation

aanorbel
Copy link
Member

No description provided.

Copy link
Contributor

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

@aanorbel aanorbel changed the title Update gradle and android core dependencies Chore: Update Gradle and Android core dependencies Aug 7, 2023
@aanorbel aanorbel requested a review from hellais August 7, 2023 07:36
Copy link
Member

@hellais hellais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to get this to work on my local system I had to install a JDK version 17.

I did this by doing:

brew install openjdk@17
sudo ln -sfn /usr/local/opt/openjdk@17/libexec/openjdk.jdk /Library/Java/JavaVirtualMachines/openjdk-17.jdk

Then I went into the android studio build settings to change the Build Tools -> Gradle settings to point to the new JDK location.

After that it builds and works as intended.

LGTM 🐳

Copy link
Contributor

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

@aanorbel aanorbel merged commit d4def50 into master Sep 9, 2023
1 check passed
@aanorbel aanorbel deleted the dependency-updates branch September 9, 2023 04:40
@aanorbel aanorbel restored the dependency-updates branch September 9, 2023 17:50
@aanorbel aanorbel deleted the dependency-updates branch October 21, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants