From ea4e68bfc96405482c1adb03c92c15ae4df2c58c Mon Sep 17 00:00:00 2001
From: Norbel AMBANUMBEN <norbel@openobservatory.org>
Date: Wed, 5 Jun 2024 09:18:47 +0100
Subject: [PATCH] feat: Update the install screen so layout matches revised
 test overview layout (#749)

Fixes  https://github.com/ooni/run/issues/175

## Proposed Changes

  - Update layout

|.|.|
|-|-|
|
![Screenshot_20240531_115726](https://github.com/ooni/probe-android/assets/17911892/503c1c07-8977-4cf5-ac9d-87ced1d3dd5e)
|
![Screenshot_20240531_115752](https://github.com/ooni/probe-android/assets/17911892/efbe8d92-4cff-4aac-93d3-1feb35541cfc)
|
---
 .../res/layout/activity_add_descriptor.xml    | 25 ++++++++++---------
 1 file changed, 13 insertions(+), 12 deletions(-)

diff --git a/app/src/main/res/layout/activity_add_descriptor.xml b/app/src/main/res/layout/activity_add_descriptor.xml
index 6d7aaaecf..73475e02a 100644
--- a/app/src/main/res/layout/activity_add_descriptor.xml
+++ b/app/src/main/res/layout/activity_add_descriptor.xml
@@ -106,9 +106,18 @@
                     tools:text="lore ipsum" />
 
                 <TextView
+                    android:id="@+id/settings"
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
-                    android:text="Install updates automatically"
+                    android:text="Test Settings"
+                    style="?attr/textAppearanceHeadline6"
+                    app:layout_constraintTop_toBottomOf="@id/description"
+                    app:layout_constraintStart_toStartOf="parent"/>
+
+                <TextView
+                    android:layout_width="wrap_content"
+                    android:layout_height="wrap_content"
+                    android:text="Install test updates automatically"
                     app:layout_constraintBottom_toBottomOf="@id/automatic_updates_switch"
                     app:layout_constraintStart_toStartOf="parent"
                     app:layout_constraintTop_toTopOf="@id/automatic_updates_switch" />
@@ -119,20 +128,12 @@
                     android:layout_height="wrap_content"
                     android:checked="true"
                     app:layout_constraintEnd_toEndOf="parent"
-                    app:layout_constraintTop_toBottomOf="@id/description" />
+                    app:layout_constraintTop_toBottomOf="@id/settings" />
 
                 <TextView
-                    android:id="@+id/run_automatically_label"
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
-                    android:text="Run automatically"
-                    app:layout_constraintEnd_toEndOf="parent"
-                    app:layout_constraintTop_toBottomOf="@id/automatic_updates_switch" />
-
-                <TextView
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:text="Tests"
+                    android:text="Run Tests automatically"
                     app:layout_constraintBottom_toBottomOf="@id/tests_checkbox"
                     app:layout_constraintStart_toStartOf="parent"
                     app:layout_constraintTop_toTopOf="@id/tests_checkbox" />
@@ -142,7 +143,7 @@
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
                     app:layout_constraintEnd_toEndOf="parent"
-                    app:layout_constraintTop_toBottomOf="@id/run_automatically_label" />
+                    app:layout_constraintTop_toBottomOf="@id/automatic_updates_switch" />
 
                 <org.openobservatory.ooniprobe.common.views.CustomExpandableListView
                     android:id="@+id/expandable_list_view"