Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

untitled "Thematic OONI Probe testing" page #296

Closed
xhdix opened this issue Oct 25, 2019 · 2 comments
Closed

untitled "Thematic OONI Probe testing" page #296

xhdix opened this issue Oct 25, 2019 · 2 comments
Assignees
Labels
bug Something isn't working priority/medium

Comments

@xhdix
Copy link
Contributor

xhdix commented Oct 25, 2019

https://ooni.org/get-involved/run/
<title>OONI - </title>
The value of {{.Title}} is not received.
https://github.com/TheTorProject/ooni-web/blob/f12b92321478e90e6e22c8039567f298db8fcb95/layouts/partials/head.html#L10

@hellais hellais added bug Something isn't working priority/medium labels Jan 16, 2020
@hellais hellais added this to the Sprint 5 - Watermelon milestone Jan 16, 2020
@hellais hellais self-assigned this Jan 16, 2020
@hellais
Copy link
Member

hellais commented Jan 16, 2020

Thanks for reporting this. I will look into fixing this in the next cycle.

@hellais
Copy link
Member

hellais commented Jan 27, 2020

I tried debugging this and it appears that we are following a very old hugo version pattern for implementing the layouts.
We should instead of using partials, rather be using the baseof.html layout, see: https://gohugo.io/templates/base/,

Implementing this change will break done for revamping the website in: #305, so I suggest we land that and then move to doing this refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority/medium
Projects
None yet
Development

No branches or pull requests

2 participants