Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent handling of duplicated search parameter #786

Open
ainghazal opened this issue Aug 16, 2022 · 1 comment
Open

inconsistent handling of duplicated search parameter #786

ainghazal opened this issue Aug 16, 2022 · 1 comment
Assignees
Labels
bug Something isn't working priority/low

Comments

@ainghazal
Copy link

ainghazal commented Aug 16, 2022

Expected Behavior

For duplicated parameters, I expect repeated parameters to be either ignored or yuxtaposed. The UI seems to indicate that (at least for the domain parameter) they are being added.

Actual Behavior

More than one parameters (in the case of domain, at least) result in a wildcard query.

Steps to Reproduce the Problem

  1. Open https://explorer.ooni.org/search?since=2022-07-17&until=2022-08-17&failure=true&probe_cc=IR&test_name=web_connectivity&domain=www.facebook.com&domain=www.example.com&probe_asn=AS197207 (duplicated domain) or https://explorer.ooni.org/search?since=2022-07-17&until=2022-08-17&failure=false&test_name=web_connectivity&domain=www.facebook.com&probe_cc=IR&probe_asn=58224&probe_asn=31549 (duplicated asn)
  2. Observe that the filter by domain or ans is not taken into account.
@majakomel majakomel self-assigned this Aug 17, 2022
@hellais hellais added bug Something isn't working priority/low labels Nov 10, 2022
@hellais
Copy link
Member

hellais commented Nov 10, 2022

Eventually once we support multiple query values for a filter (see: #812 & ooni/backend#584) we can maybe rewrite the address bar to filter by multiple domains

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority/low
Projects
None yet
Development

No branches or pull requests

3 participants